Bugzilla – Attachment 158824 Details for
Bug 35310
Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35310: Show current renewal value of the currently active check out
Bug-35310-Show-current-renewal-value-of-the-curren.patch (text/plain), 2.69 KB, created by
David Nind
on 2023-11-10 23:56:43 UTC
(
hide
)
Description:
Bug 35310: Show current renewal value of the currently active check out
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-11-10 23:56:43 UTC
Size:
2.69 KB
patch
obsolete
>From bc5f54823577446cee081855d13bc68f826409ca Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 10 Nov 2023 11:31:28 +0000 >Subject: [PATCH] Bug 35310: Show current renewal value of the currently active > check out > >Test plan, with the previous 2 patches applied: > >1) Checkout an item to Koha user, barcode 39999000003192 >2) Renew that barcode >3) Visit the items page of the biblio record, click on 'View' in front of 'Current renewals' >/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=76 >4) Notice it shows the renewals as expected >5) Return the same item: 39999000003192 >6) Repeat 1) to 3). Notice it shows 2 current renewals even tho only 1 corresponds to the currently active check out >7) Renew again. Notice it shows 3 current renewals even tho only 2 correspond to the currently active check out >7) Apply this patch. Notice it now only shows 2 current renewals > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >index 63682de50b..ad31298807 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >@@ -193,11 +193,11 @@ > [% END %] > [% END %] > </li> >- [% IF ITEM_DAT.renewals && ITEM_DAT.object.checkout %] >+ [% IF ITEM_DAT.object.checkout.renewals.count && ITEM_DAT.object.checkout %] > <li> > <span class="label">Current renewals:</span> >- [% ITEM_DAT.renewals | html %] >- [ <a class="checkout_renewals_view" data-renewals="[% ITEM_DAT.renewals | html | html %]" data-issueid="[% ITEM_DAT.object.checkout.id | html %]" href="#">View</a> ] >+ [% ITEM_DAT.object.checkout.renewals.count | html %] >+ [ <a class="checkout_renewals_view" data-renewals="[% ITEM_DAT.object.checkout.renewals.count | html | html %]" data-issueid="[% ITEM_DAT.object.checkout.id | html %]" href="#">View</a> ] > </li> > [% END %] > [% IF itemlostloop %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35310
:
158799
|
158800
|
158801
|
158822
|
158823
|
158824
|
158976
|
159723
|
159724
|
159725