Bugzilla – Attachment 158928 Details for
Bug 30070
Performance issues with edifactmsgs when you have a large number of messages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30070: (follow-up) Fix javascript errors
Bug-30070-follow-up-Fix-javascript-errors.patch (text/plain), 3.38 KB, created by
Martin Renvoize
on 2023-11-14 15:23:24 UTC
(
hide
)
Description:
Bug 30070: (follow-up) Fix javascript errors
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2023-11-14 15:23:24 UTC
Size:
3.38 KB
patch
obsolete
>From fc0110fa8a938120c41ab21bc46e41342bbbabb5 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 14 Nov 2023 07:26:59 -0500 >Subject: [PATCH] Bug 30070: (follow-up) Fix javascript errors > >--- > .../prog/en/modules/acqui/edifactmsgs.tt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt >index b21e6b76e9f..7ce04d77043 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt >@@ -139,14 +139,14 @@ > }, > { > "title": "Actions", >+ "className": "actions", > "searchable": false, > "orderable": false, >- "render": function( row, type, val, meta ) { >- >- var result = '<a class="btn btn-default btn-xs view_message" target="_blank" href="/cgi-bin/koha/acqui/edimsg.pl?id='+encodeURIComponent(row.id)+'"><i class="fa fa-search"></i> View message</a>'; >- result += '<a class="btn btn-default btn-xs delete_msg" href="/cgi-bin/koha/acqui/edifactmsgs.pl?op=delete&message_id='+encodeURIComponent(row.id)+'"><i class="fa fa-trash-can"></i> Delete</a>'; >+ "render": function(data, type, row, meta) { >+ var result = '<a class="btn btn-default btn-xs view_message" target="_blank" href="/cgi-bin/koha/acqui/edimsg.pl?id='+encodeURIComponent(row.id)+'"><i class="fa fa-search"></i> View message</a> '; >+ result += '<a class="btn btn-default btn-xs delete_msg" href="/cgi-bin/koha/acqui/edifactmsgs.pl?op=delete&message_id='+encodeURIComponent(row.id)+'"><i class="fa fa-trash-can"></i> Delete</a> '; > if ( row.status == 'new' ) { >- reslt += '<a class="btn btn-default btn-xs import_msg" href="/cgi-bin/koha/acqui/edifactmsgs.pl?op=import&message_id='+encodeURIComponent(row.id)+'"><i class="fa fa-cog"></i> Import</a>'; >+ result += '<a class="btn btn-default btn-xs import_msg" href="/cgi-bin/koha/acqui/edifactmsgs.pl?op=import&message_id='+encodeURIComponent(row.id)+'"><i class="fa fa-cog"></i> Import</a> '; > } > return result; > } >@@ -157,7 +157,7 @@ > var EDIModal = $("#EDI_modal"); > var EDIModalBody = $("#EDI_modal .modal-body"); > >- $(".view_message").on("click", function(e){ >+ $("body").on("click", ".view_message", function(e){ > e.preventDefault(); > var page = $(this).attr("href"); > EDIModalBody.load(page + " #edimsg"); >@@ -170,7 +170,7 @@ > EDIModal.on("hidden.bs.modal", function(){ > EDIModalBody.html("<div id=\"loading\"><img src=\"[% interface | html %]/[% theme | html %]/img/spinner-small.gif\" alt=\"\" /> "+_("Loading")+"</div>"); > }); >- $(".delete_msg").on("click",function(){ >+ $("body").on("click", ".delete_msg" ,function(){ > return confirm(_("Are you sure you want to delete this message?")); > }); > }); >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30070
:
158808
|
158809
|
158810
|
158887
|
158903
|
158904
|
158905
|
158906
|
158907
|
158908
|
158909
|
158910
|
158911
|
158912
|
158913
|
158914
|
158915
|
158918
|
158920
|
158922
|
158923
|
158924
|
158925
|
158926
|
158927
|
158928
|
158929
|
158930
|
158931
|
158932
|
158933
|
158934
|
158935
|
158936
|
158937
|
158938
|
158939
|
158940
|
158941
|
158942
|
158943
|
158944
|
158945
|
158946
|
158947
|
158948
|
158949
|
158950
|
158951
|
158952
|
158953
|
158954
|
158955
|
158963
|
158964
|
158965
|
158966
|
158967
|
158968
|
158969
|
158970
|
158971
|
158972
|
158973
|
158974
|
158975
|
159026
|
159027
|
159028
|
159029
|
159030
|
159031
|
159032
|
159033
|
159034
|
159035
|
159036
|
160336
|
160337
|
160338
|
160339
|
160340
|
160341
|
160342
|
160343
|
160344
|
160345
|
160346
|
160347
|
160348