Bugzilla – Attachment 158976 Details for
Bug 35310
Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35310: (QA follow-up): Remove obsolete code
Bug-35310-QA-follow-up-Remove-obsolete-code.patch (text/plain), 2.48 KB, created by
Pedro Amorim
on 2023-11-15 10:00:27 UTC
(
hide
)
Description:
Bug 35310: (QA follow-up): Remove obsolete code
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-11-15 10:00:27 UTC
Size:
2.48 KB
patch
obsolete
>From 6df37683207048d2829e2bb031342d4b722d2855 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Wed, 15 Nov 2023 10:00:45 +0000 >Subject: [PATCH] Bug 35310: (QA follow-up): Remove obsolete code > >Repeat the previous test plans, notice everything works as expected. No console errors. >--- > .../prog/en/includes/modals/checkout_renewals.inc | 1 - > koha-tmpl/intranet-tmpl/prog/js/checkout_renewals_modal.js | 4 ---- > 2 files changed, 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/checkout_renewals.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/checkout_renewals.inc >index 1748ac59b2..699473ae6f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/checkout_renewals.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/checkout_renewals.inc >@@ -8,7 +8,6 @@ > </div> <!-- /.modal-header --> > <div class="modal-body"> > <div id="retrieving" class="alert" style="display:none">Retrieving renewals...</div> >- <div id="incomplete" class="alert" style="display:none"></div> > <ul id="results" style="display:none"></ul> > </div> <!-- /.modal-body --> > <div class="modal-footer"> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkout_renewals_modal.js b/koha-tmpl/intranet-tmpl/prog/js/checkout_renewals_modal.js >index f4f57c5a78..020a1f6158 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkout_renewals_modal.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkout_renewals_modal.js >@@ -2,16 +2,12 @@ $(document).ready(function(){ > // Display the modal containing checkout renewals details > $('.checkout_renewals_view').on('click', function(e) { > e.preventDefault(); >- $('#checkoutRenewals #incomplete').html('').hide(); > $('#checkoutRenewals #results').html('').hide(); > $('#checkoutRenewals').modal({show:true}); > var renewals = $(this).data('renewals'); > var checkoutID = $(this).data('issueid'); > $('#checkoutRenewals #retrieving').show(); > $.get({ 'url': '/api/v1/checkouts/'+checkoutID+'/renewals', 'headers': { 'x-koha-embed': 'renewer' } }, function(data) { >- if (data.length < renewals) { >- $('#checkoutRenewals #incomplete').append(__("Note: %s out of %s renewals have been logged").format(data.length, renewals)).show(); >- } > var items = data.map(function(item) { > return createLi(item); > }); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35310
:
158799
|
158800
|
158801
|
158822
|
158823
|
158824
|
158976
|
159723
|
159724
|
159725