Attachment 159006 Details for Bug 35307 – Bug 35307: Add a hidden input for expired holds

[patch] Bug 35307: Add a hidden input for expired holds

Bug-35307-Add-a-hidden-input-for-expired-holds.patch (text/plain), 1.72 KB, created by Victor Grousset/tuxayo on 2023-11-15 20:01:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2023-11-15 20:01:17 UTC

Size: 1.72 KB

patch

obsolete

>From 05b90196108a466d5e8f8d45328aa68594d7ee79 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 13 Nov 2023 16:02:46 +0000
>Subject: [PATCH] Bug 35307: Add a hidden input for expired holds
>
>To test:
> 1 - Place 3 holds on a bib, each for a different patron
> 2 - IN the db, set the first hold to be expired:
>    UPDATE reserves SET expirationdate='2023-01-01' WHERE reserve_id=1;
> 3 - Refresh the holds page for the biblio
> 4 - Note the first hold now says 'Expired' in the expiration date column
> 5 - Set an expiration date for the last hold
> 6 - Click 'Update holds'
> 7 - Note the date is applied to the second hold
> 8 - Delete the holds
> 9 - Apply patch
>10 - Repeat 1-6
>11 - Confirm only the correct hold is updated
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
>index 141ab2ab27..24905d7d24 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
>@@ -133,6 +133,7 @@
>                     <input type="text" class="flatpickr" data-flatpickr-futuredate="true" value="[% hold.expirationdate | html %]" size="10" name="expirationdate" />
>                 [% ELSE %]
>                     <span class="expiredon"><label>Expired:</label> [% hold.expirationdate | $KohaDates %]</span>
>+                    <input type="hidden" value="[% hold.expirationdate | html %]" name="expirationdate" />
>                 [% END %]
>             </td>
>             <td>
>-- 
>2.42.1

Actions: View | Diff | Splinter Review

Attachments on bug 35307: 158888 | 158957 | 159006