Attachment 159054 Details for Bug 35352 – Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField

[patch] Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField

Bug-35352-Allow-SMSalertnumber-to-be-hidden-via-Bo.patch (text/plain), 2.71 KB, created by Lucas Gass (lukeg) on 2023-11-16 15:00:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-11-16 15:00:31 UTC

Size: 2.71 KB

patch

obsolete

>From a1e0f64a5c0a032b197219e3bd4e6a0c43efbe25 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 16 Nov 2023 14:58:56 +0000
>Subject: [PATCH] Bug 35352: Allow SMSalertnumber to be hidden via
> BorrowerUnwantedField
>
>To test:
>1. Add a value to SMSSendDriver like 'Emial'.
>2. Go to BorrowerUnwantedField and attempt to hide "Mobile phone number (smsalertnumber)"
>3. Go to members/memberentry.pl and see the field is not hidden.
>4. APPLY PATCH
>5. Try step 3 again and this time the field should be properly hidden.
>
>Note: This patch also includes some indentation changes.
>---
> .../prog/en/modules/members/memberentrygen.tt        | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index b6b70882e67..e1fbc890161 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -1625,11 +1625,13 @@ legend:hover {
>                                         <input type="hidden" name="setting_messaging_prefs" value="1" />
>                                         [% INCLUDE 'messaging-preference-form.inc' %]
>                                         [% IF ( SMSSendDriver ) %]
>-                                            <p>
>-                                                <label for="SMSnumber">SMS number:</label>
>-                                                <input type="text" id="SMSnumber" name="SMSnumber" value="[% SMSnumber | html %]" />
>-                                                <span class="hint sms_number_help">Please enter numbers only. Prefix the number with + or 00 if including the country code.</span>
>-                                            </p>
>+                                            [% IF !nosmsalertnumber %]
>+                                                <p>
>+                                                    <label for="SMSnumber">SMS number:</label>
>+                                                    <input type="text" id="SMSnumber" name="SMSnumber" value="[% SMSnumber | html %]" />
>+                                                    <span class="hint sms_number_help">Please enter numbers only. Prefix the number with + or 00 if including the country code.</span>
>+                                                </p>
>+                                            [% END %]
>                                             [% IF SMSSendDriver == 'Email' && !nosms_provider_id %]
>                                                 <p>
>                                                     <label for="sms_provider_id">SMS provider:</label>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35352: 159054 | 159068 | 159074