Attachment 159079 Details for Bug 35348 – Bug 35348: Ensure users can access cookie details in staff client

[patch] Bug 35348: Ensure users can access cookie details in staff client

Bug-35348-Ensure-users-can-access-cookie-details-i.patch (text/plain), 1.66 KB, created by Martin Renvoize (ashimema) on 2023-11-17 11:27:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-11-17 11:27:41 UTC

Size: 1.66 KB

patch

obsolete

>From 96d8589c1cae497939863b568118edb5f28eab4f Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 17 Nov 2023 11:08:08 +0000
>Subject: [PATCH] Bug 35348: Ensure users can access cookie details in staff
> client
>
>We remove the check on JSConsents content so that when cookie consent is
>enabled we retain the option for users to get more information about
>what cookies are being used.
>
>Test plan
>1) Enable CookieConsents
>2) Do not add any tracking cookies for the staff client into
>   CookieConsentedJS preference
>3) Note that 'My consents' appears in the user menu
>4) Clicking 'My consents' opens the 'Cookie consent' modal displaying
>   information about the cookies used.
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/header.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
>index b67f82c8386..a3c8152b3ea 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
>@@ -206,7 +206,7 @@
>                             <a class="toplinks" href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% loggedinusernumber | html %]">My checkouts</a>
>                         </li>
>                     [% END %]
>-                    [% IF Koha.Preference( 'CookieConsent' ) && JSConsents.all('staffConsent').size %]
>+                    [% IF Koha.Preference( 'CookieConsent' ) %]
>                         <li class="toplinks-myconsents">
>                             <a id="viewCookieConsents" href="#" class="toplinks">My consents</a>
>                         </li>
>-- 
>2.42.0

Actions: View | Diff | Splinter Review

Attachments on bug 35348: 159059 | 159078 | 159079 | 159080 | 159091 | 159092 | 159093 | 159444 | 159445 | 159446 | 165568 | 165569 | 165570 | 165632 | 165633 | 165634