Bugzilla – Attachment 159109 Details for
Bug 35331
Add an ILL table actions plugin hook
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35331: (QA follow-up): Patron ILL history
Bug-35331-QA-follow-up-Patron-ILL-history.patch (text/plain), 2.58 KB, created by
Kyle M Hall (khall)
on 2023-11-17 18:32:28 UTC
(
hide
)
Description:
Bug 35331: (QA follow-up): Patron ILL history
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2023-11-17 18:32:28 UTC
Size:
2.58 KB
patch
obsolete
>From 6424bd0773f7cce2b36fdeb8b46b29143c915a2c Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Thu, 16 Nov 2023 10:01:16 +0000 >Subject: [PATCH] Bug 35331: (QA follow-up): Patron ILL history > >With the previous patches applied and successfull test plans, access the users ILL history page, visit: >/cgi-bin/koha/members/ill-requests.pl?borrowernumber=51 > >Notice you get an error. >Apply this patch, and try again, notice the error is gone and the custom plugin action is also in the patron's ILL history table > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/members/ill-requests.tt | 2 ++ > members/ill-requests.pl | 8 +++++--- > 2 files changed, 7 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt >index cea915d5953..8843022f0f0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt >@@ -68,6 +68,8 @@ > var prefilters = '[% prefilters | html %]'; > // Set column settings > var table_settings = [% TablesSettings.GetTableSettings( 'illrequests', 'ill-requests', 'ill-requests', 'json' ) | $raw %]; >+ >+ var ill_table_actions = [% table_actions | $raw %]; > </script> > [% INCLUDE 'ill-list-table-strings.inc' %] > [% Asset.js("js/ill-list-table.js") | $raw %] >diff --git a/members/ill-requests.pl b/members/ill-requests.pl >index f2b23844c07..d4573fabf3b 100755 >--- a/members/ill-requests.pl >+++ b/members/ill-requests.pl >@@ -22,6 +22,7 @@ use Modern::Perl; > use CGI qw ( -utf8 ); > use C4::Auth qw( get_template_and_user ); > use C4::Output qw( output_and_exit_if_error output_and_exit output_html_with_http_headers ); >+use JSON qw( encode_json ); > use Koha::Patrons; > > my $input = CGI->new; >@@ -42,9 +43,10 @@ my $patron = Koha::Patrons->find( $borrowernumber ); > output_and_exit_if_error( $input, $cookie, $template, { module => 'members', logged_in_user => $logged_in_user, current_patron => $patron } ); > > $template->param( >- prefilters => "borrowernumber=$borrowernumber", >- patron => $patron, >- illview => 1, >+ prefilters => "borrowernumber=$borrowernumber", >+ patron => $patron, >+ illview => 1, >+ table_actions => encode_json( Koha::Illrequest->get_staff_table_actions ), > ); > > output_html_with_http_headers $input, $cookie, $template->output; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35331
:
158916
|
158917
|
158993
|
159037
|
159046
|
159047
|
159048
|
159049
|
159105
|
159106
|
159107
|
159108
|
159109
|
160634
|
160635
|
160636
|
160637
|
162812
|
162813
|
162814
|
162815
|
162816