Bugzilla – Attachment 159111 Details for
Bug 20844
Reset a hold when it is missing after allocation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20844: (follow-up) Fix alert boxes for item-level holds
Bug-20844-follow-up-Fix-alert-boxes-for-item-level.patch (text/plain), 1.87 KB, created by
Emily Lamancusa (emlam)
on 2023-11-17 19:42:57 UTC
(
hide
)
Description:
Bug 20844: (follow-up) Fix alert boxes for item-level holds
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2023-11-17 19:42:57 UTC
Size:
1.87 KB
patch
obsolete
>From d74c5d55ac33dbbdff0b7367b3c50e0b17d18ae5 Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Fri, 17 Nov 2023 13:56:06 -0500 >Subject: [PATCH] Bug 20844: (follow-up) Fix alert boxes for item-level holds > >Fix styling on the alert in additem.tt >Don't show alert in moredetail page if RevertBibLevelHolds is disabled >--- > catalogue/moredetail.pl | 6 +++++- > .../intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 2 +- > 2 files changed, 6 insertions(+), 2 deletions(-) > >diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl >index 78f0b830af..0db48af071 100755 >--- a/catalogue/moredetail.pl >+++ b/catalogue/moredetail.pl >@@ -248,7 +248,11 @@ foreach my $item (@items){ > ); > > $item_info->{nomod} = !$patron->can_edit_items_from( $item->homebranch ); >- $item_info->{waiting_holds} = $item->holds({ found => [ 'W', 'T' ], item_level_hold => { '!=' => 0 } })->count; >+ >+ if ( C4::Context->preference('RevertLostBibLevelHolds') ) { >+ $item_info->{waiting_holds} = >+ $item->holds( { found => [ 'W', 'T' ], item_level_hold => { '!=' => 0 } } )->count; >+ } > > push @item_data, $item_info; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >index 931787e64c..0962bc7a28 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >@@ -87,7 +87,7 @@ > [% IF item_not_found %]<div class="dialog alert"><strong>Cannot delete</strong>: Item not found.</div>[% END %] > > [% IF waitinglostitems %] >- <div class="alert"> >+ <div class="dialog alert"> > The following item(s) have a waiting item-level hold and have been marked as lost. > <ul> > [% FOREACH i IN waitinglostitems %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20844
:
79267
|
80760
|
80761
|
80890
|
80891
|
81045
|
81531
|
81623
|
81624
|
81640
|
81697
|
81698
|
81710
|
81711
|
81712
|
102334
|
102335
|
102336
|
113208
|
113209
|
113210
|
118264
|
118265
|
118266
|
125437
|
125438
|
125439
|
140214
|
140215
|
140216
|
150348
|
150349
|
150350
|
150480
|
159062
|
159063
|
159064
|
159065
|
159111
|
170263
|
170264