Attachment 159123 Details for Bug 31694 – Bug 31694: (follow-up) Fix preset display issue

[patch] Bug 31694: (follow-up) Fix preset display issue

Bug-31694-follow-up-Fix-preset-display-issue.patch (text/plain), 1.90 KB, created by David Nind on 2023-11-19 20:52:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-11-19 20:52:37 UTC

Size: 1.90 KB

patch

obsolete

>From a01c7c412640df2d78cc9e2a27a8666b95326e4b Mon Sep 17 00:00:00 2001
>From: Shi Yao Wang <shi-yao.wang@inlibro.com>
>Date: Fri, 2 Dec 2022 16:06:35 -0500
>Subject: [PATCH] Bug 31694: (follow-up) Fix preset display issue
>
>Preset column should now display the right preset.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/en/modules/admin/marc-overlay-rules.tt      | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt
>index a1ae41be9c..7a6064a135 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt
>@@ -431,11 +431,11 @@
>         };
> 
>         var overlay_rules_label_to_value = {};
>-        overlay_rules_label_to_value["add"] = 1;
>-        overlay_rules_label_to_value["append"] = 1;
>-        overlay_rules_label_to_value["remove"] = 1;
>-        overlay_rules_label_to_value["delete"] = 1;
>-        overlay_rules_label_to_value["skip"] = 0;
>+        overlay_rules_label_to_value[_("Add")] = 1;
>+        overlay_rules_label_to_value[_("Append")] = 1;
>+        overlay_rules_label_to_value[_("Remove")] = 1;
>+        overlay_rules_label_to_value[_("Delete")] = 1;
>+        overlay_rules_label_to_value[_("Skip")] = 0;
> 
>         function hash_config(config) {
>           return JSON.stringify(config, Object.keys(config).sort());
>@@ -459,7 +459,7 @@
>             operations_config[$operation.data('operation')] = overlay_rules_label_to_value[$operation.text()];
>           });
>           $('.rule-preset', $this).text(
>-            operations_config_overlay_rule_preset(operations_config) || _("Custom")
>+            $('option[value="' + operations_config_overlay_rule_preset(operations_config) + '"]').text() || _("Custom")
>           );
>         });
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31694: 141401 | 142579 | 142580 | 142598 | 144407 | 144408 | 144409 | 149601 | 149602 | 155123 | 155124 | 155125 | 155126 | 159121 | 159122 | 159123 | 159124 | 159192 | 159250 | 159251 | 159252 | 159253 | 160194 | 160195 | 160196 | 160197 | 160198