Bugzilla – Attachment 159127 Details for
Bug 32776
Choose to convert oldest reserve or all possible reserves to recalls
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32776: Stop recalled items from being recalled by other holds being converted on same record
Bug-32776-Stop-recalled-items-from-being-recalled-.patch (text/plain), 1.55 KB, created by
Aleisha Amohia
on 2023-11-19 21:52:22 UTC
(
hide
)
Description:
Bug 32776: Stop recalled items from being recalled by other holds being converted on same record
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2023-11-19 21:52:22 UTC
Size:
1.55 KB
patch
obsolete
>From ccc4c42760df2aec44e14da5cf4e3a546d6333c0 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleisha@catalyst.net.nz> >Date: Sun, 19 Nov 2023 21:50:41 +0000 >Subject: [PATCH] Bug 32776: Stop recalled items from being recalled by other > holds being converted on same record > >--- > misc/cronjobs/recalls/convert_holds_to_recalls.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/misc/cronjobs/recalls/convert_holds_to_recalls.pl b/misc/cronjobs/recalls/convert_holds_to_recalls.pl >index 176fdd16760..961595b4da4 100755 >--- a/misc/cronjobs/recalls/convert_holds_to_recalls.pl >+++ b/misc/cronjobs/recalls/convert_holds_to_recalls.pl >@@ -127,8 +127,8 @@ foreach my $bib ( @bib_holds ) { > my $item_to_allocate = $itemnumber_to_allocate == $item->id ? $item : Koha::Items->find( $itemnumber_to_allocate ); > do_convert( $hold_to_convert, $item_to_allocate ); > report( $hold_to_convert, ++$count ); >+ $this_record_holds_converted++; > } >- $this_record_holds_converted++; > } > } > } >@@ -160,7 +160,7 @@ sub can_convert { > } else { > # bib-level reserve > >- if ( $item and $item->can_be_recalled({ patron => $patron, hold_convert => 1 }) ) { >+ if ( $item and $item->can_be_recalled({ patron => $patron, hold_convert => 1 }) and Koha::Recalls->filter_by_current->search({ item_id => $item->id })->count < 1 ) { > # this item may be able to fill the recall > return $item->id; > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32776
:
145987
|
145988
|
157004
|
157005
|
157006
|
157007
|
157178
|
157966
|
158015
|
159125
|
159126
| 159127