Bugzilla – Attachment 159139 Details for
Bug 35335
Circulation history tab in patron information causes 500 error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35335: Fix 500 error on circulation history tab
Bug-35335-Fix-500-error-on-circulation-history-tab.patch (text/plain), 1.82 KB, created by
Peter Vashchuk
on 2023-11-20 13:37:14 UTC
(
hide
)
Description:
Bug 35335: Fix 500 error on circulation history tab
Filename:
MIME Type:
Creator:
Peter Vashchuk
Created:
2023-11-20 13:37:14 UTC
Size:
1.82 KB
patch
obsolete
>From 7507cfd02eab3ed7d9adf49202c744076fe255c4 Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Thu, 16 Nov 2023 16:49:07 +0200 >Subject: [PATCH] Bug 35335: Fix 500 error on circulation history tab > >The 500 error was caused by this problem: >Koha::Patron->issuer is not covered by tests! > >To reproduce: >1. Change syspref RecordStaffUserOnCheckout to "record" >2. Choose a customer who has borrowed something before (has circulation history) and go to that customers Circulation History tab to check if it can be seen. >3. Borrow something and go check that customer again, but this time you will see 500 error. >4. Apply the patch. >5. Check customer's Circulation History tab again, now it should work as intended. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >index b45cf35308..cd5ea03e52 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >@@ -118,7 +118,7 @@ > </td> > <td>[% Branches.GetName( checkout.branchcode ) | html %]</td> > [% IF Koha.Preference('RecordStaffUserOnCheckout') %] >- [% SET issuer = checkout.issuer %] >+ [% SET issuer = issuer.borrowernumber %] > <td><a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% issuer.issuer_id | uri %]">[% issuer.firstname | html %] [% issuer.surname | html %]</a></td> > [% END %] > <td data-order="[% checkout.date_due | html %]"> >-- >2.42.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35335
:
159053
|
159138
|
159139
|
159156
|
159157
|
159219