Attachment 159155 Details for Bug 35374 – Bug 35374: Remove ES6 template literals to fix translation strings

[patch] Bug 35374: Remove ES6 template literals to fix translation strings

Bug-35374-Remove-ES6-template-literals-to-fix-tran.patch (text/plain), 1.57 KB, created by Jonathan Druart on 2023-11-21 12:42:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-11-21 12:42:16 UTC

Size: 1.57 KB

patch

obsolete

>From 060260496be3c5cacc7605e0da34835a69fa082b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 21 Nov 2023 13:36:17 +0100
>Subject: [PATCH] Bug 35374: Remove ES6 template literals to fix translation
> strings
>
>The .po files contains the whole block after this line. I don't really
>understand what's happening but this change fixes the problem.
>
>Test plan:
>1. Run the following command before and after the patch and compare the
>diff
>% gulp po:update --lang de-DE --task messages-js
>2. Confirm that the list on this vue is correctly populated
>---
> .../vue/components/ERM/UsageStatisticsProviderDataList.vue   | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsProviderDataList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsProviderDataList.vue
>index 2f4d8ee1c38..0f0f6a2ef74 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsProviderDataList.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsProviderDataList.vue
>@@ -57,7 +57,10 @@ export default {
>                 )
>         },
>         table_url() {
>-            let url = `/api/v1/erm/usage_${this.data_type}s?usage_data_provider_id=${this.$route.params.usage_data_provider_id}`
>+            let url = "/api/v1/erm/usage_%ss?usage_data_provider_id=%s".format(
>+                this.data_type,
>+                this.$route.params.usage_data_provider_id
>+            )
>             return url
>         },
>         getTableColumns() {
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 35374: 159155 | 159172 | 159194 | 159195