Attachment 159214 Details for Bug 35356 – Bug 35356: Show SMS labels only when data exists

[patch] Bug 35356: Show SMS labels only when data exists

Bug-35356-Show-SMS-labels-only-when-data-exists.patch (text/plain), 2.58 KB, created by Victor Grousset/tuxayo on 2023-11-23 20:15:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2023-11-23 20:15:51 UTC

Size: 2.58 KB

patch

obsolete

>From ddf4d0d738d843c42abdfd0db2bcdcca635139c1 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 17 Nov 2023 21:39:02 +0000
>Subject: [PATCH] Bug 35356: Show SMS labels only when data exists
>
>To test:
>APPLY PATCH
>1. Set SMSSendDriver = Email
>2. Admin > SMS cellular providers, have at least 1.
>3. Go to the members/moremember.pl
>4. If the patron has no SMSnumber or SMS provider then niether of the labels should appear.
>5. Add both a SMSnumber and SMS provider, make sure the data appears correctly on members/moremember.pl.
>
>Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> .../prog/en/modules/members/moremember.tt | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 3a1278e3cf..095c6e35dc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -354,11 +354,13 @@
> [% IF Koha.Preference('SMSSendDriver') %]
> <div class="rows">
> <ol>
>- <li>
>- SMS number:
>- <a href="sms:[% patron.smsalertnumber | uri %]">[% patron.smsalertnumber | html %]</a>
>- </li>
>- [% IF Koha.Preference( 'SMSSendDriver') == 'Email' %]
>+ [% IF patron.smsalertnumber %]
>+ <li>
>+ SMS number:
>+ <a href="sms:[% patron.smsalertnumber | uri %]">[% patron.smsalertnumber | html %]</a>
>+ </li>
>+ [% END %]
>+ [% IF Koha.Preference( 'SMSSendDriver') == 'Email' && patron.sms_provider.name %]
> <li>
> SMS provider:
> [% patron.sms_provider.name | html %]
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 35356: 159114 | 159117 | 159214