Bugzilla – Attachment 159345 Details for
Bug 35145
Add ability to order patron attributes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35145: (follow-up) Quiet perltidy warnings
Bug-35145-follow-up-Quiet-perltidy-warnings.patch (text/plain), 1.70 KB, created by
Owen Leonard
on 2023-11-29 16:00:27 UTC
(
hide
)
Description:
Bug 35145: (follow-up) Quiet perltidy warnings
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2023-11-29 16:00:27 UTC
Size:
1.70 KB
patch
obsolete
>From b9d2f9baebd648bc59a42f62024cdf7ac5e0cef5 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 29 Nov 2023 15:48:21 +0000 >Subject: [PATCH] Bug 35145: (follow-up) Quiet perltidy warnings > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > Koha/Schema/Result/BorrowerAttributeType.pm | 4 ++-- > .../mysql/atomicupdate/bug_35145_order_patron_attributes.pl | 6 ++++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > >diff --git a/Koha/Schema/Result/BorrowerAttributeType.pm b/Koha/Schema/Result/BorrowerAttributeType.pm >index dbf5383459..c008b1d7b8 100644 >--- a/Koha/Schema/Result/BorrowerAttributeType.pm >+++ b/Koha/Schema/Result/BorrowerAttributeType.pm >@@ -176,8 +176,8 @@ __PACKAGE__->add_columns( > { data_type => "tinyint", default_value => 0, is_nullable => 0 }, > "mandatory", > { data_type => "tinyint", default_value => 0, is_nullable => 0 }, >- "number", >- { data_type => "int", is_nullable => 1 }, >+ "number", >+ { data_type => "int", is_nullable => 1 }, > ); > > =head1 PRIMARY KEY >diff --git a/installer/data/mysql/atomicupdate/bug_35145_order_patron_attributes.pl b/installer/data/mysql/atomicupdate/bug_35145_order_patron_attributes.pl >index ac5a0520e2..9fe71f2edd 100755 >--- a/installer/data/mysql/atomicupdate/bug_35145_order_patron_attributes.pl >+++ b/installer/data/mysql/atomicupdate/bug_35145_order_patron_attributes.pl >@@ -8,10 +8,12 @@ return { > my ( $dbh, $out ) = @$args{qw(dbh out)}; > > # Do you stuffs here >- $dbh->do(q{ >+ $dbh->do( >+ q{ > ALTER TABLE borrower_attribute_types > ADD number int(11); >- }); >+ } >+ ); > > # Print useful stuff here > # tables >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35145
:
159182
|
159193
|
159344
|
159345
|
162347
|
162348
|
162619
|
162620
|
162621
|
162622
|
162676
|
166473
|
166519
|
166520
|
166521
|
169256
|
169257
|
169258
|
170330
|
170331
|
170332
|
170627
|
170628
|
170629
|
176756
|
176757
|
176758
|
176760
|
176761
|
176762
|
176763
|
176764
|
176765
|
177119