Bugzilla – Attachment 159363 Details for
Bug 25835
Include overdue report (under circulation module) as a staff permission
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25835: Include overdues with fines in overdues_report permission
Bug-25835-Include-overdues-with-fines-in-overduesr.patch (text/plain), 3.82 KB, created by
Andrew Fuerste-Henry
on 2023-11-29 18:06:53 UTC
(
hide
)
Description:
Bug 25835: Include overdues with fines in overdues_report permission
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2023-11-29 18:06:53 UTC
Size:
3.82 KB
patch
obsolete
>From b6413ab1db900d1278fad56e11be6cf8151ff8c8 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrewfh@dubcolib.org> >Date: Wed, 29 Nov 2023 18:02:52 +0000 >Subject: [PATCH] Bug 25835: Include overdues with fines in overdues_report > permission > >To test: >1 - have a user with circulate_remaining_permissions but not overdues_report >2 - confirm user can see and run Overdues with Fines >3 - apply patch >4 - confirm user can no longer see links to Overdues with Fines or load the page directly by entering the url >5 - confirm a user with overdues_report or greate permission can see and use the tool >--- > circ/branchoverdues.pl | 2 +- > koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc | 4 ++-- > .../intranet-tmpl/prog/en/modules/circ/circulation-home.tt | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/circ/branchoverdues.pl b/circ/branchoverdues.pl >index 84414ded334..bce79d8cf80 100755 >--- a/circ/branchoverdues.pl >+++ b/circ/branchoverdues.pl >@@ -42,7 +42,7 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user({ > template_name => "circ/branchoverdues.tt", > query => $input, > type => "intranet", >- flagsrequired => { circulate => "circulate_remaining_permissions" }, >+ flagsrequired => { circulate => "overdues_report" }, > }); > > my $default = C4::Context->userenv->{'branch'}; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc >index e10a4805897..83372281df1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc >@@ -109,16 +109,16 @@ > </li> > </ul> > >+ [% IF ( CAN_user_circulate_overdues_report ) %] > <h5>Overdues</h5> > <ul> >- [% IF ( CAN_user_circulate_overdues_report ) %] > <li> > <a href="/cgi-bin/koha/circ/overdue.pl" title="Warning: This report is very resource intensive on systems with large numbers of overdue items.">Overdues</a> > </li> >- [% END %] > <li> > <a href="/cgi-bin/koha/circ/branchoverdues.pl" title="Limited to your library. See report help for other details.">Overdues with fines</a> > </li> > </ul> >+ [% END %] > </div> > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt >index f6dab7a0136..cec04724898 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt >@@ -139,17 +139,16 @@ > </li> > </ul> > >+ [% IF ( CAN_user_circulate_overdues_report ) %] > <h3>Overdues</h3> > > <ul class="buttons-list"> >- [% IF ( CAN_user_circulate_overdues_report ) %] > <li> > <a class="circ-button" > href="/cgi-bin/koha/circ/overdue.pl" > title="Warning: This report is very resource intensive on systems with large numbers of overdue items." > ><i class="fa-solid fa-clock"></i> Overdues</a> > </li> >- [% END %] > <li> > <a class="circ-button" > href="/cgi-bin/koha/circ/branchoverdues.pl" >@@ -157,6 +156,7 @@ > ><i class="fa-solid fa-clock"></i> Overdues with fines</a> > </li> > </ul> >+ [% END %] > </div> > </div> > <div class="row" id="intranet-circulation-home-html"> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25835
:
159363
|
159364
|
160592