Bugzilla – Attachment 159371 Details for
Bug 35408
ERM > Titles > Import from a list gives an invalid link to the import job
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35408: Fix import job link
Bug-35408-Fix-import-job-link.patch (text/plain), 3.03 KB, created by
Victor Grousset/tuxayo
on 2023-11-29 20:04:15 UTC
(
hide
)
Description:
Bug 35408: Fix import job link
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2023-11-29 20:04:15 UTC
Size:
3.03 KB
patch
obsolete
>From aafc3fe35275b206eb1832ee9bd795195850ed2e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 28 Nov 2023 09:11:43 +0100 >Subject: [PATCH] Bug 35408: Fix import job link > >After importing titles from a list there is a link to the background job >that is displayed. >This link points to /cgi-bin/koha/admin/background_jobs/:id >There is a route to this path in routes/erm.js, to redirect to the >correct URI /cgi-bin/koha/admin/background_jobs.pl?op=view&id=:id >However this link will not work if we are accessing it from outside the >ERM app/module, or if we are opening it in a new tab/window. > >The idea was interesting, but does not work... > >Test plan: >Create a new ERM local package, a new list (virtual shelf), add some >items to the list. >Go to E-resource management > eHoldings > Local > Titles > Import from a list >Click "import" >Notice the "see job" link and click it > >=> Confirm that with this patch applied you can open it in a new tab >without getting a 404 > >Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > .../components/ERM/EHoldingsLocalTitlesFormImport.vue | 7 +++++-- > koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js | 9 --------- > 2 files changed, 5 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesFormImport.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesFormImport.vue >index fc3133b61c..9e2ec2b136 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesFormImport.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesFormImport.vue >@@ -2,9 +2,12 @@ > <h2>{{ $__("Import from a list") }}</h2> > <div v-if="job_id" class="dialog message"> > {{ $__("Import in progress,") }} >- <router-link :to="`/cgi-bin/koha/admin/background_jobs/${job_id}`"> >+ <a >+ :href="`/cgi-bin/koha/admin/background_jobs.pl?op=view&id=${job_id}`" >+ target="_blank" >+ > > {{ $__("see job #%s").format(job_id) }} >- </router-link> >+ </a> > </div> > <fieldset id="package_list" class="rows"> > {{ $__("To the following local package") }}: >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js >index 105744d8a2..4f2331bdda 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js >@@ -30,15 +30,6 @@ import UsageStatisticsReportsViewer from "../components/ERM/UsageStatisticsRepor > import { $__ } from "../i18n"; > > export const routes = [ >- { >- path: "/cgi-bin/koha/admin/background_jobs/:id", >- is_base: true, >- beforeEnter(to, from, next) { >- window.location.href = >- "/cgi-bin/koha/admin/background_jobs.pl?op=view&id=" + >- to.params.id; >- }, >- }, > { > path: "/cgi-bin/koha/erm/erm.pl", > is_default: true, >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35408
:
159284
|
159309
| 159371