Attachment 159483 Details for Bug 34977 – Bug 34977: The "Patron Lists" only allows deleting one list at a time

[patch] Bug 34977: The "Patron Lists" only allows deleting one list at a time

Bug-34977-The-Patron-Lists-only-allows-deleting-on.patch (text/plain), 1.63 KB, created by Salah Ghedda on 2023-12-01 20:17:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Salah Ghedda

Created: 2023-12-01 20:17:12 UTC

Size: 1.63 KB

patch

obsolete

>From 04daa1346db77f66974f8d7a27e483ba62083be9 Mon Sep 17 00:00:00 2001
>From: Salah Ghedds <salah.ghedda@inLibro.com>
>Date: Wed, 4 Oct 2023 14:43:54 -0400
>Subject: [PATCH] Bug 34977: The "Patron Lists" only allows deleting one list
> at a time
>
>In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once.
>
>TEST PLAN
>1. Apply the patch.
>2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list).
>3. Select the lists you want to delete.
>4. Click the "Delete selected lists" button.
>5. Confirm that the selected lists have been deleted.
>6. Ensure that the button cannot be used if no list is selected.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> patron_lists/delete.pl | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/patron_lists/delete.pl b/patron_lists/delete.pl
>index e7c227ea1f..e2b34abc90 100755
>--- a/patron_lists/delete.pl
>+++ b/patron_lists/delete.pl
>@@ -36,15 +36,15 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>     }
> );
> 
>-my $id        = $cgi->param('patron_list_id');
>+my $id = $cgi->param('patron_list_id');
> my @lists_ids = $cgi->multi_param('patron_lists_ids');
> 
>-if ( defined $id && $id ne '' ) {
>-    DelPatronList( { patron_list_id => $id } );
>+if (defined $id && $id ne '') {
>+    DelPatronList({ patron_list_id => $id });
> }
> if (@lists_ids) {
>     foreach my $list_id (@lists_ids) {
>-        DelPatronList( { patron_list_id => $list_id } );
>+        DelPatronList({ patron_list_id => $list_id });
>     }
> }
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 34977: 156553 | 156554 | 156562 | 158349 | 158350 | 159483 | 159484