Attachment 159588 Details for Bug 35489 – Bug 35489: Add a hidden input for itemnumber even if item has no barcode

[patch] Bug 35489: Add a hidden input for itemnumber even if item has no barcode

Bug-35489.patch (text/plain), 2.90 KB, created by Nick Clemens (kidclamp) on 2023-12-05 15:50:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-12-05 15:50:52 UTC

Size: 2.90 KB

patch

obsolete

>From 2581df802a7fddb67676066c91972dc7c4d2a850 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 5 Dec 2023 15:47:23 +0000
>Subject: [PATCH] Bug 35489:
>
>This page is a ingle form, all fields must have inputs to avoid data loss/mismatch
>
>To test:
>1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without
>2 - Place an item level hold on the item with no barcode
>3 - Place another hold for a different patron on the item with a barcode
>4 - From the holds table add an expiration date to the hold with a barcode and save
>5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold
>6 - Delete the holds
>7 - Apply patch
>8 - Repeat 2-4
>9 - Confirm the itemnumbers for the holds have not changed
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
>index f443a7e1978..7172c526f0c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
>@@ -167,10 +167,10 @@
>                         <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% hold.biblionumber | uri %]&amp;itemnumber=[% hold.itemnumber | uri %]#item[% hold.itemnumber | uri %]">
>                             [%- IF ( hold.barcodenumber ) -%]
>                                 [%- hold.barcodenumber | html -%]
>-                                <input type="hidden" name="itemnumber" value="[% hold.itemnumber | html %]" />
>                             [%- ELSE -%]
>                                 <span>No barcode</span>
>                             [%- END -%]
>+                            <input type="hidden" name="itemnumber" value="[% hold.itemnumber | html %]" />
>                         </a>
>                     [%- ELSE -%]
>                         [%- IF ( hold.item_level_hold ) -%]
>@@ -179,10 +179,10 @@
>                                 <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% hold.biblionumber | uri %]&amp;itemnumber=[% hold.itemnumber | uri %]#item[% hold.itemnumber | uri %]">
>                                     [%- IF ( hold.barcodenumber ) -%]
>                                         [%- hold.barcodenumber | html -%]
>-                                        <input type="hidden" name="itemnumber" value="[% hold.itemnumber | html %]" />
>                                     [%- ELSE -%]
>                                         <span>No barcode</span>
>                                     [%- END -%]
>+                                    <input type="hidden" name="itemnumber" value="[% hold.itemnumber | html %]" />
>                                 </a>
>                             </em>
>                         [%- ELSE -%]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35489: 159588 | 159607 | 159929 | 160573