Attachment 159622 Details for Bug 35498 – Bug 35498: Allow tab to indent lines and trigger autocomplete

[patch] Bug 35498: Allow tab to indent lines and trigger autocomplete

Bug-35498-Allow-tab-to-indent-lines-and-trigger-au.patch (text/plain), 1.94 KB, created by Matt Blenkinsop on 2023-12-06 15:17:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2023-12-06 15:17:44 UTC

Size: 1.94 KB

patch

obsolete

>From c7ffe31011f9242cc9b1874c4ec6a4cca3ac73af Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Wed, 6 Dec 2023 15:13:20 +0000
>Subject: [PATCH] Bug 35498: Allow tab to indent lines and trigger autocomplete
>
>This patch allows the tab key to indent lines as well as trigger autocomplete.
>
>Test plan:
>1) Apply patch, navigate to reports and create a new SQL report
>2) Click in the text editor and press tab, it should indent and then trigger the autocomplete options
>3) Type something to select from the autocomplete box and press tab - it should autocomplete that option
>4) Type any word and then press space. Now press tab and it should indent again
>---
> .../prog/en/modules/reports/guided_reports_start.tt           | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 07f18eb2a9..7df8aaf082 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -1586,7 +1586,7 @@
>                     "\\[\\[(.*?)\\]\\]":"style1",
>                     "<<(.*?)>>":"style1"
>                 },
>-                extraKeys: {"Tab": "autocomplete"}, //enable tab to accept auto-complete
>+                // extraKeys: {"Tab": "autocomplete"}, //enable tab to accept auto-complete
>                 hint: CodeMirror.hint.sql,
>                 hintOptions: {
>                     tables: [% To.json(tables) | $raw %]
>@@ -1594,7 +1594,7 @@
>             });
>             var ExcludedTriggerKeys = { //key-code combinations of keys that will not fire the auto-complete script
>                 "8": "backspace",
>-                "9": "tab",
>+                // "9": "tab",
>                 "13": "enter",
>                 "16": "shift",
>                 "17": "ctrl",
>-- 
>2.37.1 (Apple Git-137.1)

Actions: View | Diff | Splinter Review

Attachments on bug 35498: 159622 | 159623 | 159625 | 159626