Attachment 159675 Details for Bug 30645 – Bug 30645: Add tests

[patch] Bug 30645: Add tests

Bug-30645-Add-tests.patch (text/plain), 4.75 KB, created by David Nind on 2023-12-08 18:23:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-12-08 18:23:18 UTC

Size: 4.75 KB

patch

obsolete

>From 7a289cf81bf72cbcc2734fc069245f28d7587d7c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 28 Apr 2022 15:13:17 +0200
>Subject: [PATCH] Bug 30645: Add tests
>
>to highlight the problem
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> t/db_dependent/selenium/patrons_search.t | 40 ++++++++++++++++++------
> 1 file changed, 30 insertions(+), 10 deletions(-)
>
>diff --git a/t/db_dependent/selenium/patrons_search.t b/t/db_dependent/selenium/patrons_search.t
>index 928e64f36f..78ea22209c 100755
>--- a/t/db_dependent/selenium/patrons_search.t
>+++ b/t/db_dependent/selenium/patrons_search.t
>@@ -61,7 +61,7 @@ my $builder       = t::lib::TestBuilder->new;
> my $schema        = Koha::Database->schema;
> 
> subtest 'Search patrons' => sub {
>-    plan tests => 27;
>+    plan tests => 28;
> 
>     if ( Koha::Patrons->search({surname => {-like => "test_patron_%"}})->count ) {
>         BAIL_OUT("Cannot run this test, data we need to create already exist in the DB");
>@@ -152,7 +152,7 @@ subtest 'Search patrons' => sub {
>             searched_by_default => 0
>         }
>     )->store;
>-    my $attribute_type_searchable = Koha::Patron::Attribute::Type->new(
>+    my $attribute_type_searchable_1 = Koha::Patron::Attribute::Type->new(
>         {
>             code             => 'my code2',
>             description      => 'my description2',
>@@ -161,26 +161,37 @@ subtest 'Search patrons' => sub {
>             searched_by_default => 1
>         }
>     )->store;
>-    my $attribute_type_searchable_not_default = Koha::Patron::Attribute::Type->new(
>+    my $attribute_type_searchable_2 = Koha::Patron::Attribute::Type->new(
>         {
>-            code             => 'mycode3',
>+            code             => 'my code3',
>             description      => 'my description3',
>             opac_display     => 1,
>             staff_searchable => 1,
>+            searched_by_default => 1
>+        }
>+    )->store;
>+    my $attribute_type_searchable_not_default = Koha::Patron::Attribute::Type->new(
>+        {
>+            code             => 'mycode4',
>+            description      => 'my description4',
>+            opac_display     => 1,
>+            staff_searchable => 1,
>             searched_by_default => 0
>         }
>     )->store;
>-    push @cleanup, $attribute_type, $attribute_type_searchable, $attribute_type_searchable_not_default;
>+    push @cleanup, $attribute_type, $attribute_type_searchable_1, $attribute_type_searchable_2, $attribute_type_searchable_not_default;
> 
>     $patrons[0]->extended_attributes([
>         { code => $attribute_type->code, attribute => 'test_attr_1' },
>-        { code => $attribute_type_searchable->code, attribute => 'test_attr_2'},
>-        { code => $attribute_type_searchable_not_default->code, attribute => 'test_attr_3'},
>+        { code => $attribute_type_searchable_1->code, attribute => 'test_attr_2'},
>+        { code => $attribute_type_searchable_2->code, attribute => 'test_attr_3'},
>+        { code => $attribute_type_searchable_not_default->code, attribute => 'test_attr_4'},
>     ]);
>     $patrons[1]->extended_attributes([
>         { code => $attribute_type->code, attribute => 'test_attr_1' },
>-        { code => $attribute_type_searchable->code, attribute => 'test_attr_2'},
>-        { code => $attribute_type_searchable_not_default->code, attribute => 'test_attr_3'},
>+        { code => $attribute_type_searchable_1->code, attribute => 'test_attr_2'},
>+        { code => $attribute_type_searchable_2->code, attribute => 'test_attr_3'},
>+        { code => $attribute_type_searchable_not_default->code, attribute => 'test_attr_4'},
>     ]);
> 
>     my $total_number_of_patrons = Koha::Patrons->search->count;
>@@ -304,8 +315,17 @@ subtest 'Search patrons' => sub {
>     # clear form
>     $driver->find_element('//form[@id="patron_search_form"]//*[@id="clear_search"]')->click();
> 
>+    $s->fill_form( { search_patron_filter => 'test_attr_3' } ); # Terms must be split
>+    $s->submit_form;
>+    sleep $DT_delay && $s->wait_for_ajax;
>+
>+    is( $driver->find_element('//div[@id="'.$table_id.'_info"]')->get_text, sprintf('Showing 1 to %s of %s entries (filtered from %s total entries)', 2, 2, $total_number_of_patrons), 'Searching on a searchable attribute returns correct results' );
>+
>+    # clear form
>+    $driver->find_element('//form[@id="patron_search_form"]//*[@id="clear_search"]')->click();
>+
>     # Search on searchable attribute as specific field, we expect 2 patrons
>-    $s->fill_form( { search_patron_filter => 'test_attr_3' } );
>+    $s->fill_form( { search_patron_filter => 'test_attr_4' } );
>     $driver->find_element('//form[@id="patron_search_form"]//*[@id="searchfieldstype_filter"]//option[@value="_ATTR_'.$attribute_type_searchable_not_default->code.'"]')->click();
>     $s->submit_form;
>     sleep $DT_delay && $s->wait_for_ajax;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30645: 134253 | 154949 | 159414 | 159450 | 159651 | 159652 | 159675 | 159676 | 160208 | 160216 | 161495 | 161528 | 164982 | 165009 | 165010 | 165011