Bugzilla – Attachment 159709 Details for
Bug 35529
Avoid 'click' for links in library administration
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35529: Avoid 'click' in link in library administration
Bug-35529-Avoid-click-in-link-in-library-administr.patch (text/plain), 3.05 KB, created by
David Nind
on 2023-12-11 09:54:21 UTC
(
hide
)
Description:
Bug 35529: Avoid 'click' in link in library administration
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-12-11 09:54:21 UTC
Size:
3.05 KB
patch
obsolete
>From 2c0144b53c59f8921f0305cb19a4be64230ee4bc Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 10 Dec 2023 15:10:34 +0000 >Subject: [PATCH] Bug 35529: Avoid 'click' in link in library administration > >It's not necessary to label a link with 'click', it being >a link and being formatted as such is enough. > >To test: >* Go to administration > libraries >* Edit any library >* Verify link texts for UserCSS and UserJS > * Click to edit > * Click to collapse >* Apply patch, restart all >* Verify links have been updated, click removed > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >index 1a38417ff4..c8d547097d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >@@ -291,17 +291,17 @@ > <li> > <label for="UserJS">UserJS: </label> > <div style="display:flex; flex-direction:column;"> >- <a class="expand-textarea" id="expand_opacuserjs" data-target="opacuserjs" data-syntax="javascript" href="#">Click to edit</a> >+ <a class="expand-textarea" id="expand_opacuserjs" data-target="opacuserjs" data-syntax="javascript" href="#">Edit</a> > <textarea style="display:none" name="opacuserjs" id="opacuserjs" class="codemirror" rows="10" cols="40">[% library.opacuserjs | html %]</textarea> >- <a class="collapse-textarea" id="collapse_opacuserjs" data-target="opacuserjs" data-syntax="javascript" style="display:none" href="#">Click to collapse</br></a> >+ <a class="collapse-textarea" id="collapse_opacuserjs" data-target="opacuserjs" data-syntax="javascript" style="display:none" href="#">Collapse</br></a> > </div> > </li> > <li> > <label for="UserCSS">UserCSS: </label> > <div style="display:flex; flex-direction:column;"> >- <a class="expand-textarea" id="expand_opacusercss" data-target="opacusercss" data-syntax="css" href="#">Click to edit</a> >+ <a class="expand-textarea" id="expand_opacusercss" data-target="opacusercss" data-syntax="css" href="#">Edit</a> > <textarea style="display:none" name="opacusercss" id="opacusercss" class="" rows="10" cols="40">[% library.opacusercss | html %]</textarea> >- <a class="collapse-textarea" id="collapse_opacusercss" data-target="opacusercss" data-syntax="css" style="display:none" href="#">Click to collapse</br></a> >+ <a class="collapse-textarea" id="collapse_opacusercss" data-target="opacusercss" data-syntax="css" style="display:none" href="#">Collapse</br></a> > </div> > </li> > </li> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35529
:
159700
|
159709
|
160190