Bugzilla – Attachment 159723 Details for
Bug 35310
Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35310: Only show 'Current renewals' <li> entry if there are current renewals
Bug-35310-Only-show-Current-renewals-li-entry-if-t.patch (text/plain), 2.86 KB, created by
Martin Renvoize (ashimema)
on 2023-12-12 11:04:53 UTC
(
hide
)
Description:
Bug 35310: Only show 'Current renewals' <li> entry if there are current renewals
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-12-12 11:04:53 UTC
Size:
2.86 KB
patch
obsolete
>From e3f74dd2ce45ba1d2a63f595d34c2e7f5ef80819 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 10 Nov 2023 11:00:55 +0000 >Subject: [PATCH] Bug 35310: Only show 'Current renewals' <li> entry if there > are current renewals > >'Current renewals' is always showing, even if empty. > >Test plan: >1) Checkout an item to Koha user, barcode 39999000003192 >2) Renew that barcode >3) Visit the items page of the biblio record, click on "View" in front of "Current renewals" >/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=76 >4) Notice all items have the 'Current renewals' label entry, but only the checked out item in step 1) has the 'Current renewals' label entry >5) Apply patch. Notice only the item with current renewals is showing the 'Current renewals' label entry with the respective value. > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../prog/en/modules/catalogue/moredetail.tt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >index c24aa47c8ae..f96a1f9e9f8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >@@ -193,13 +193,13 @@ > [% END %] > [% END %] > </li> >- <li> >- <span class="label">Current renewals:</span> >- [% ITEM_DAT.renewals | html %] >- [% IF ITEM_DAT.renewals %] >- [ <a class="checkout_renewals_view" data-renewals="[% ITEM_DAT.renewals | html | html %]" data-issueid="[% ITEM_DAT.object.checkout.id | html %]" href="#">View</a> ] >- [% END %] >- </li> >+ [% IF ITEM_DAT.renewals %] >+ <li> >+ <span class="label">Current renewals:</span> >+ [% ITEM_DAT.renewals | html %] >+ [ <a class="checkout_renewals_view" data-renewals="[% ITEM_DAT.renewals | html | html %]" data-issueid="[% ITEM_DAT.object.checkout.id | html %]" href="#">View</a> ] >+ </li> >+ [% END %] > [% IF itemlostloop %] > <li> > <span class="label">Lost status:</span> >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35310
:
158799
|
158800
|
158801
|
158822
|
158823
|
158824
|
158976
| 159723 |
159724
|
159725