Attachment 159764 Details for Bug 28844 – Bug 28844: Replace GetSuggestionFromBiblionumber

[patch] Bug 28844: Replace GetSuggestionFromBiblionumber

Bug-28844-Replace-GetSuggestionFromBiblionumber.patch (text/plain), 1.68 KB, created by Nick Clemens (kidclamp) on 2023-12-12 18:27:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-12-12 18:27:51 UTC

Size: 1.68 KB

patch

obsolete

>From 57e04746b8cc33c970600f20bc2b3b64c21dcd7a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 10 May 2023 15:21:05 +0200
>Subject: [PATCH] Bug 28844: Replace GetSuggestionFromBiblionumber
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> C4/Acquisition.pm | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
>diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
>index 370030895ef..08f606da4a7 100644
>--- a/C4/Acquisition.pm
>+++ b/C4/Acquisition.pm
>@@ -22,7 +22,7 @@ use Modern::Perl;
> use Carp qw( carp croak );
> use Text::CSV_XS;
> use C4::Context;
>-use C4::Suggestions qw( GetSuggestion GetSuggestionFromBiblionumber ModSuggestion );
>+use C4::Suggestions qw( GetSuggestion ModSuggestion );
> use C4::Biblio qw( GetMarcFromKohaField GetMarcStructure IsMarcStructureInternal );
> use C4::Contract qw( GetContract );
> use C4::Log qw( logaction );
>@@ -1387,12 +1387,14 @@ sub ModReceiveOrder {
>     $order->{invoice_unitprice} ||= $order->{unitprice};
>     $order->{invoice_currency}  ||= Koha::Acquisition::Currencies->get_active->currency;
> 
>-    my $suggestionid = GetSuggestionFromBiblionumber( $biblionumber );
>-    if ($suggestionid) {
>-        ModSuggestion( {suggestionid=>$suggestionid,
>-                        STATUS=>'AVAILABLE',
>-                        biblionumber=> $biblionumber}
>-                        );
>+    if ( $order->{suggestionid} ) {
>+        ModSuggestion(
>+            {
>+                suggestionid => $order->{suggestionid},
>+                STATUS       => 'AVAILABLE',
>+                biblionumber => $biblionumber
>+            }
>+        );
>     }
> 
>     my $result_set = $dbh->selectrow_arrayref(
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 28844: 151001 | 151002 | 151003 | 151004 | 151005 | 151006 | 151007 | 153157 | 153158 | 153159 | 153160 | 153161 | 153162 | 153163 | 153174 | 153175 | 153176 | 158982 | 158983 | 158984 | 158985 | 158986 | 158987 | 158988 | 158989 | 158990 | 159759 | 159760 | 159761 | 159762 | 159763 | 159764 | 159765 | 159766 | 159767 | 159768