Bugzilla – Attachment 159768 Details for
Bug 28844
Suggestion from existing title can alert patron in error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28844: (follow-up) Adjust suggestion id comparison
Bug-28844-follow-up-Adjust-suggestion-id-compariso.patch (text/plain), 998 bytes, created by
Nick Clemens (kidclamp)
on 2023-12-12 18:28:01 UTC
(
hide
)
Description:
Bug 28844: (follow-up) Adjust suggestion id comparison
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-12-12 18:28:01 UTC
Size:
998 bytes
patch
obsolete
>From e0bb1698da7bbafbc1316368207c9495b648669c Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 12 Dec 2023 18:23:42 +0000 >Subject: [PATCH] Bug 28844: (follow-up) Adjust suggestion id comparison > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > acqui/addorder.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/acqui/addorder.pl b/acqui/addorder.pl >index 01bfabc8eaf..bd55caf69e9 100755 >--- a/acqui/addorder.pl >+++ b/acqui/addorder.pl >@@ -349,7 +349,7 @@ if ( $basket->{is_standing} || $orderinfo->{quantity} ne '0' ) { > # change suggestion status if applicable > if ( my $suggestionid = $input->param('suggestionid') ) { > # Double checking we are going to edit the correct suggestion >- if ( $suggestionid == $order->suggestion->suggestion ) { >+ if ( $suggestionid == $order->suggestion->id ) { > ModSuggestion( > { > suggestionid => $suggestionid, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28844
:
151001
|
151002
|
151003
|
151004
|
151005
|
151006
|
151007
|
153157
|
153158
|
153159
|
153160
|
153161
|
153162
|
153163
|
153174
|
153175
|
153176
|
158982
|
158983
|
158984
|
158985
|
158986
|
158987
|
158988
|
158989
|
158990
|
159759
|
159760
|
159761
|
159762
|
159763
|
159764
|
159765
|
159766
|
159767
| 159768