Bugzilla – Attachment 159856 Details for
Bug 35578
Validate "Where" in OPAC Authority search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35578: Validate "Where" in OPAC Authority search
Bug-35578-Validate-Where-in-OPAC-Authority-search.patch (text/plain), 2.20 KB, created by
David Cook
on 2023-12-15 00:17:09 UTC
(
hide
)
Description:
Bug 35578: Validate "Where" in OPAC Authority search
Filename:
MIME Type:
Creator:
David Cook
Created:
2023-12-15 00:17:09 UTC
Size:
2.20 KB
patch
obsolete
>From 1eccf3e51af556f3d728092c69d72a4fd15d28c6 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Fri, 15 Dec 2023 00:14:05 +0000 >Subject: [PATCH] Bug 35578: Validate "Where" in OPAC Authority search > >This patch adds validation to the "Where" field in OPAC Authority search. > >Test plan: >0. Apply the patch and koha-plack --reload kohadev >1. Go to http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl >2. Type "test" into "Term(s)" field >3. Click "Submit" >4. Confirm a result is found > >5. Repeat the above using "Where" values of "in the complete record", >"in any heading", and "in main entry" > >6. Using the HTML inspector in the browser, change the value of >the selected option of the "marclist" select element to >"this is broken" >7. Click "Submit" >8. Confirm a result is found (ie it's not throwing a fatal error >anymore) >--- > opac/opac-authorities-home.pl | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > >diff --git a/opac/opac-authorities-home.pl b/opac/opac-authorities-home.pl >index 8b2145ab15..ba011bd014 100755 >--- a/opac/opac-authorities-home.pl >+++ b/opac/opac-authorities-home.pl >@@ -47,7 +47,7 @@ my ( $template, $loggedinuser, $cookie ); > my $authority_types = Koha::Authority::Types->search({}, { order_by => ['authtypetext']}); > > if ( $op eq "do_search" ) { >- my @marclist = $query->multi_param('marclist'); >+ my @input_marclist = $query->multi_param('marclist'); > my @and_or = $query->multi_param('and_or'); > my @excluding = $query->multi_param('excluding'); > my @operator = $query->multi_param('operator'); >@@ -55,6 +55,21 @@ if ( $op eq "do_search" ) { > my @value = $query->multi_param('value'); > $value[0] ||= q||; > >+ my $valid_marc_list = { >+ "all" => 1, >+ "match" => 1, >+ "mainentry" => 1, >+ }; >+ my @marclist = (); >+ foreach my $entry (@input_marclist) { >+ if ( $valid_marc_list->{$entry} ) { >+ push( @marclist, $entry ); >+ } >+ } >+ if ( !@marclist ) { >+ push( @marclist, 'all' ); >+ } >+ > my $builder = Koha::SearchEngine::QueryBuilder->new( > { index => $Koha::SearchEngine::AUTHORITIES_INDEX } ); > my $searcher = Koha::SearchEngine::Search->new( >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35578
:
159856
|
159926
|
160984
|
160985
|
161235
|
161236