Bugzilla – Attachment 159877 Details for
Bug 35574
Bookings page should require only manage_bookings permissions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35574: Bookings tab from biblio details should only require manage_bookings permission
Bug-35574-Bookings-tab-from-biblio-details-should-.patch (text/plain), 1.30 KB, created by
Martin Renvoize (ashimema)
on 2023-12-15 11:07:53 UTC
(
hide
)
Description:
Bug 35574: Bookings tab from biblio details should only require manage_bookings permission
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-12-15 11:07:53 UTC
Size:
1.30 KB
patch
obsolete
>From 89bc6916cdd8206a24ccb412da6fe27ff3315e8b Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 14 Dec 2023 17:10:35 +0000 >Subject: [PATCH] Bug 35574: Bookings tab from biblio details should only > require manage_bookings permission > >TO test: >1 - Find or create a staff user >2 - Grant permissions: > circulate: manage_bookings, circ_remaining_permissions > catalogue >3 - Open a record details, go to items tab, mark an item as bookable >4 - Sign out and sign in as the patron above (or use a private window to sign in) >5 - Place a booking on the record located above >6 - Success >7 - Try to view the bookings tab >8 - Fail, you don't have permission >9 - Apply patch >10 - Success! > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > bookings/list.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/bookings/list.pl b/bookings/list.pl >index 66fbd0f4528..6333287e041 100755 >--- a/bookings/list.pl >+++ b/bookings/list.pl >@@ -30,7 +30,7 @@ my ( $template, $borrowernumber, $cookie, $flags ) = get_template_and_user( > template_name => "bookings/list.tt", > query => $input, > type => "intranet", >- flagsrequired => { circulate => 1 }, >+ flagsrequired => { circulate => 'manage_bookings' }, > } > ); > >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35574
:
159851
|
159852
|
159853
|
159874
|
159875
|
159876
|
159877
|
159878
|
159879
|
159880
|
159886
|
159887
|
159888
|
159889
|
159890
|
159896
|
159897
|
159898
|
159899
|
159900