Bugzilla – Attachment 159890 Details for
Bug 35574
Bookings page should require only manage_bookings permissions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35574: Tidy
Bug-35574-Tidy.patch (text/plain), 1.91 KB, created by
Nick Clemens (kidclamp)
on 2023-12-15 12:35:47 UTC
(
hide
)
Description:
Bug 35574: Tidy
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-12-15 12:35:47 UTC
Size:
1.91 KB
patch
obsolete
>From a954b72a4de193d01c17c09ebd242fc25af1adce Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 15 Dec 2023 12:22:53 +0000 >Subject: [PATCH] Bug 35574: Tidy > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/api/v1/biblios.t | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > >diff --git a/t/db_dependent/api/v1/biblios.t b/t/db_dependent/api/v1/biblios.t >index f73fc31da5e..5bd719a9f32 100755 >--- a/t/db_dependent/api/v1/biblios.t >+++ b/t/db_dependent/api/v1/biblios.t >@@ -696,12 +696,10 @@ subtest 'get_bookings() tests' => sub { > my $item1 = $builder->build_sample_item( { bookable => 1, biblionumber => $biblio->id } ); > my $item2 = $builder->build_sample_item( { bookable => 1, biblionumber => $biblio->id } ); > >- $t->get_ok("//$unauth_userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/bookings") >- ->status_is(403); >+ $t->get_ok( "//$unauth_userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/bookings" )->status_is(403); > >- $t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/bookings") >- ->status_is(200) >- ->json_is( '' => [], 'No bookings on the biblio' ); >+ $t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/bookings" )->status_is(200) >+ ->json_is( '' => [], 'No bookings on the biblio' ); > > # One booking > my $start_0 = dt_from_string->subtract( days => 2 )->truncate( to => 'day' ); >@@ -718,9 +716,8 @@ subtest 'get_bookings() tests' => sub { > } > ); > >- my $ret = $t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/bookings") >- ->status_is(200) >- ->tx->res->json; >+ my $ret = $t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/bookings" )->status_is(200) >+ ->tx->res->json; > > is_deeply( $ret, [ $booking_0->to_api ] ); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35574
:
159851
|
159852
|
159853
|
159874
|
159875
|
159876
|
159877
|
159878
|
159879
|
159880
|
159886
|
159887
|
159888
|
159889
|
159890
|
159896
|
159897
|
159898
|
159899
|
159900