Attachment 159900 Details for Bug 35574 – Bug 35574: Tidy

[patch] Bug 35574: Tidy

Bug-35574-Tidy.patch (text/plain), 1.96 KB, created by Tomás Cohen Arazi (tcohen) on 2023-12-15 19:27:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2023-12-15 19:27:55 UTC

Size: 1.96 KB

patch

obsolete

>From f9b3873f83885dd0220735f66aa634bacec82752 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 15 Dec 2023 12:22:53 +0000
>Subject: [PATCH] Bug 35574: Tidy
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> t/db_dependent/api/v1/biblios.t | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
>diff --git a/t/db_dependent/api/v1/biblios.t b/t/db_dependent/api/v1/biblios.t
>index f73fc31da5e..5bd719a9f32 100755
>--- a/t/db_dependent/api/v1/biblios.t
>+++ b/t/db_dependent/api/v1/biblios.t
>@@ -696,12 +696,10 @@ subtest 'get_bookings() tests' => sub {
>     my $item1  = $builder->build_sample_item( { bookable => 1, biblionumber => $biblio->id } );
>     my $item2  = $builder->build_sample_item( { bookable => 1, biblionumber => $biblio->id } );
> 
>-    $t->get_ok("//$unauth_userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/bookings")
>-      ->status_is(403);
>+    $t->get_ok( "//$unauth_userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/bookings" )->status_is(403);
> 
>-    $t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/bookings")
>-      ->status_is(200)
>-      ->json_is( '' => [], 'No bookings on the biblio' );
>+    $t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/bookings" )->status_is(200)
>+        ->json_is( '' => [], 'No bookings on the biblio' );
> 
>     # One booking
>     my $start_0   = dt_from_string->subtract( days => 2 )->truncate( to => 'day' );
>@@ -718,9 +716,8 @@ subtest 'get_bookings() tests' => sub {
>         }
>     );
> 
>-    my $ret = $t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/bookings")
>-      ->status_is(200)
>-      ->tx->res->json;
>+    my $ret = $t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/bookings" )->status_is(200)
>+        ->tx->res->json;
> 
>     is_deeply( $ret, [ $booking_0->to_api ] );
> 
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 35574: 159851 | 159852 | 159853 | 159874 | 159875 | 159876 | 159877 | 159878 | 159879 | 159880 | 159886 | 159887 | 159888 | 159889 | 159890 | 159896 | 159897 | 159898 | 159899 | 159900