Bugzilla – Attachment 159927 Details for
Bug 35477
Adding non-existent items to the waiting list should display a warning
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35477: (QA follow-up): tidy up code
Bug-35477-QA-follow-up-tidy-up-code.patch (text/plain), 2.85 KB, created by
Victor Grousset/tuxayo
on 2023-12-16 21:34:25 UTC
(
hide
)
Description:
Bug 35477: (QA follow-up): tidy up code
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2023-12-16 21:34:25 UTC
Size:
2.85 KB
patch
obsolete
>From 66ed80a48dfbd0ab6a331114e641b274a7d3ece4 Mon Sep 17 00:00:00 2001 >From: Victor Grousset/tuxayo <victor@tuxayo.net> >Date: Sat, 16 Dec 2023 22:22:15 +0100 >Subject: [PATCH] Bug 35477: (QA follow-up): tidy up code > >--- > .../components/Preservation/WaitingList.vue | 38 +++++++++++-------- > 1 file changed, 23 insertions(+), 15 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/WaitingList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/WaitingList.vue >index 97ce6bf654..484b218f02 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/WaitingList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/WaitingList.vue >@@ -135,8 +135,13 @@ export default { > const PreservationStore = inject("PreservationStore") > const { config } = PreservationStore > >- const { setMessage, setWarning, setConfirmationDialog, loading, loaded } = >- inject("mainStore") >+ const { >+ setMessage, >+ setWarning, >+ setConfirmationDialog, >+ loading, >+ loaded, >+ } = inject("mainStore") > > return { > table, >@@ -214,20 +219,23 @@ export default { > client.waiting_list_items.createAll(items).then( > result => { > if (result.length) { >- if (result.length != items.length ){ >- this.setWarning( >- this.$__("%s new items added. %s items not found.").format( >- result.length, items.length - result.length >- ), >- true >- ) >+ if (result.length != items.length) { >+ this.setWarning( >+ this.$__( >+ "%s new items added. %s items not found." >+ ).format( >+ result.length, >+ items.length - result.length >+ ), >+ true >+ ) > } else { >- this.setMessage( >- this.$__("%s new items added.").format( >- result.length >- ), >- true >- ) >+ this.setMessage( >+ this.$__("%s new items added.").format( >+ result.length >+ ), >+ true >+ ) > } > this.last_items = result > if (this.$refs.table) { >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35477
:
159580
|
159611
|
159927
|
160387
|
160388
|
160533