Attachment 159934 Details for Bug 35106 – Bug 35106: Add patron search autocomplete to Patron ID input

[patch] Bug 35106: Add patron search autocomplete to Patron ID input

Bug-35106-Add-patron-search-autocomplete-to-Patron.patch (text/plain), 2.42 KB, created by David Nind on 2023-12-17 23:46:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-12-17 23:46:20 UTC

Size: 2.42 KB

patch

obsolete

>From afb436fbdf23aa8a4a4c968efaed2598bbebd3ea Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Thu, 19 Oct 2023 09:35:32 +0000
>Subject: [PATCH] Bug 35106: Add patron search autocomplete to Patron ID input
>
>Test plan, k-t-d:
>1) Install FreeForm and enable ILLmodule, run:
>bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
>2) Visit /cgi-bin/koha/ill/ill-requests.pl
>3) Create 'New ILL request'
>4) Select the request type, input cardnumber '42' and select a library. Hit 'Create'
>5) Manage the request created just now: click the request id or 'manage request' button from the table
>6) Click "Edit request" from the top actions toolbar
>7) Input text in Patron ID e.g. 'koha'. Notice you get patron suggestions.
>8) Click one of the suggestions and save the request, notice the patron is saved correctly.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/en/modules/ill/ill-requests.tt            | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>index 87d73fc747..cb55d907e3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>@@ -396,7 +396,7 @@
>                 
> 
>                 [% ELSIF query_type == 'edit_action' %]
>-                    <form method="POST" action="/cgi-bin/koha/ill/ill-requests.pl">
>+                    <form method="POST" id="ill_edit_action_form" action="/cgi-bin/koha/ill/ill-requests.pl">
>                         <fieldset class="rows">
>                             <legend>Request details</legend>
>                             <ol>
>@@ -945,6 +945,18 @@
>                 $('.ill_checkout_due_date').show();
>             }
>         });
>+
>+        if ($("#ill_edit_action_form #borrowernumber").length) {
>+            patron_autocomplete(
>+                $('#ill_edit_action_form #borrowernumber'), {
>+                    'on-select-callback': function(event, ui) {
>+                        $("#ill_edit_action_form #borrowernumber").val(ui.item.patron_id);
>+                        return false;
>+                    }
>+                }
>+            );
>+        }
>+
>     </script>
>     [% INCLUDE 'ill-list-table-strings.inc' %]
>     [% INCLUDE 'ill-batch-table-strings.inc' %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35106: 157421 | 157422 | 157498 | 157499 | 159934 | 159935 | 164258 | 164259 | 164260 | 165543 | 165544 | 165545