Bugzilla – Attachment 159939 Details for
Bug 35204
REST API: POST endpoint /auth/password/validation dies on patron with expired password
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35204: Prevent an expired password from throwing a 500 error
Bug-35204-Prevent-an-expired-password-from-throwin.patch (text/plain), 1.68 KB, created by
Matt Blenkinsop
on 2023-12-18 11:01:10 UTC
(
hide
)
Description:
Bug 35204: Prevent an expired password from throwing a 500 error
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2023-12-18 11:01:10 UTC
Size:
1.68 KB
patch
obsolete
>From 209374d5f07ac6bab9984ea5d6c07b926eae1299 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Wed, 6 Dec 2023 10:03:45 +0000 >Subject: [PATCH] Bug 35204: Prevent an expired password from throwing a 500 > error > >Currently when a patron with an expired password is authenticated via the API a 500 error is returned rather than a 400 "Validation failed" error. This patch catches the return value for an expired password and returns the validation failure before the patron search is attempted. > >Test plan: >1) Choose a patron and set their password expiry date to a date in the past >2) Send a request to auth/password/validation as an authenticated user with that patron's details >3) The response should be a 500 error >4) Apply patch >5) Repeat steps 1-3 and this time the response should be a 400 code with an error message of "Password expired" >--- > Koha/REST/V1/Auth/Password.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/Koha/REST/V1/Auth/Password.pm b/Koha/REST/V1/Auth/Password.pm >index 4369ffd187..80632312b4 100644 >--- a/Koha/REST/V1/Auth/Password.pm >+++ b/Koha/REST/V1/Auth/Password.pm >@@ -72,10 +72,11 @@ sub validate { > > return try { > my ( $status, $THE_cardnumber, $THE_userid ) = C4::Auth::checkpw( $identifier, $password ); >- unless ($status) { >+ unless ($status && $status > 0) { >+ my $error_response = $status == -2 ? 'Password expired' : 'Validation failed'; > return $c->render( > status => 400, >- openapi => { error => "Validation failed" } >+ openapi => { error => $error_response } > ); > } > >-- >2.37.1 (Apple Git-137.1)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35204
:
159612
|
159939
|
159940
|
159956
|
159957