Attachment 160011 Details for Bug 35455 – Bug 35455: Remove = in ICU for indexing/searching

[patch] Bug 35455: Remove = in ICU for indexing/searching

Bug-35455-Remove--in-ICU-for-indexingsearching.patch (text/plain), 2.52 KB, created by Martin Renvoize (ashimema) on 2023-12-19 15:05:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-12-19 15:05:57 UTC

Size: 2.52 KB

patch

obsolete

>From da578a93f2f8629944c895eed410596570d62254 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Fri, 1 Dec 2023 02:36:56 +0000
>Subject: [PATCH] Bug 35455: Remove = in ICU for indexing/searching
>
>This change more closely aligns ICU and CHR so that ICU also
>removes the = character. This fixes issues in ICU when searching
>with a : which gets transformed into a =. Without this change,
>the Analytics features won't work for titles with a colon in them.
>
>Test plan:
>0. Apply the patch and import bibs from Bugzilla (using Staged MARC tools)
>1. cp ./etc/zebradb/etc/phrases-icu.xml /etc/koha/zebradb/etc/phrases-icu.xml
>2. cp ./etc/zebradb/etc/words-icu.xml /etc/koha/zebradb/etc/words-icu.xml
>3. vi /etc/koha/zebradb/etc/default.idx
>Change "charmap word-phrase-utf.chr" to "icuchain words-icu.xml" for "index w"
>and "icuchain phrases-icu.xml" for "index p"
>4. koha-zebra --stop kohadev
>5. pkill zebrasrv
>6. koha-zebra --start kohadev
>7. koha-rebuild-zebra -a -b -f -v kohadev
>
>8. Search for "Awesome title" and open the detail page
>9. Note that the "Analytics: Show analytics" line shows up
>10. Click that link
>11. Note that it opens the "Cool article" record and it displays
>"In: Awesome title: awesome subtitle"
>12. Click that link
>13. Note that it opens the "Awesome title" record
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> etc/zebradb/etc/phrases-icu.xml | 1 +
> etc/zebradb/etc/words-icu.xml   | 1 +
> 2 files changed, 2 insertions(+)
>
>diff --git a/etc/zebradb/etc/phrases-icu.xml b/etc/zebradb/etc/phrases-icu.xml
>index 5045a49d5ea..7409143db7c 100644
>--- a/etc/zebradb/etc/phrases-icu.xml
>+++ b/etc/zebradb/etc/phrases-icu.xml
>@@ -6,6 +6,7 @@
>   
>   <transform rule="[\x00-\x08\x0B\x0C\x0E-\x1F\x7F] Any-Remove"/>
>   <transform rule="[:Punctuation:] Remove"/>
>+  <transform rule="[=] Remove"/>
>   <transform rule="NFD"/>
>   <transform rule="[:Nonspacing Mark:] Remove"/>
>   <transform rule="NFC"/>
>diff --git a/etc/zebradb/etc/words-icu.xml b/etc/zebradb/etc/words-icu.xml
>index 2eb3e7be5f6..372854a1730 100644
>--- a/etc/zebradb/etc/words-icu.xml
>+++ b/etc/zebradb/etc/words-icu.xml
>@@ -9,6 +9,7 @@
>   <transliterate rule="[:Number:] { '-' > '' "/>
>   
>   <transform rule="[\x00-\x08\x0B\x0C\x0E-\x1F\x7F] Any-Remove"/>
>+  <transform rule="[=] Remove"/>
>   <tokenize rule="l"/>
>   <transform rule="[[:WhiteSpace:][:Punctuation:]] Remove"/>
>   <transform rule="NFD"/>
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 35455: 159422 | 159423 | 159424 | 159512 | 160011