Attachment 160023 Details for Bug 35600 – Bug 35600: Prevent checkouts table to flicker

[patch] Bug 35600: Prevent checkouts table to flicker

Bug-35600-Prevent-checkouts-table-to-flicker.patch (text/plain), 2.59 KB, created by Lucas Gass (lukeg) on 2023-12-19 15:32:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-12-19 15:32:43 UTC

Size: 2.59 KB

patch

obsolete

>From 03378df5f34adea1551ce6499ee6f3a3af28f7e0 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 19 Dec 2023 11:45:59 +0100
>Subject: [PATCH] Bug 35600: Prevent checkouts table to flicker
>
>The checkouts table is displayed in the DOM then hidden in JS, then we show it if the cookie is set.
>
>This patch makes the table hidden by default, and show it if/when needed
>
>Test plan:
>Check an item out, see the checkouts list view
>Play with "Always show checkouts automatically", refresh the page
>=> UI should behave better than before this patch
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc | 4 ++--
> koha-tmpl/intranet-tmpl/prog/js/checkouts.js                 | 2 --
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc
>index 8d51af2e25..9efd8065d9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc
>@@ -16,7 +16,7 @@
>         </p>
>     </div>
>     <form name="issues" action="/cgi-bin/koha/tools/export.pl" method="post">
>-        <table id="issues-table" style="width: 100% !Important;">
>+        <table id="issues-table" style="width: 100% !Important; display: none;">
>             <thead>
>                 <tr>
>                     <th scope="col">&nbsp;</th>
>@@ -49,7 +49,7 @@
>         <label for="issues-table-load-immediately">Always show checkouts automatically</label>
>         <input id="issues-table-load-immediately" type="checkbox" />
> 
>-        <div id="issues-table-actions">
>+        <div id="issues-table-actions" style="display: none;">
>             <fieldset class="action">
>                 [% IF ( CAN_user_circulate_override_renewals ) %]
>                     [% IF Koha.Preference( 'AllowRenewalLimitOverride' ) || Koha.Preference( 'AllowRenewalOnHoldOverride' ) %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>index b9db3f384f..bebe986679 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>@@ -265,8 +265,6 @@ $(document).ready(function() {
> 
>     var ymd = flatpickr.formatDate(new Date(), "Y-m-d");
> 
>-    $('#issues-table').hide();
>-    $('#issues-table-actions').hide();
>     $('#issues-table-load-immediately').change(function(){
>         if ( this.checked && typeof issuesTable === 'undefined') {
>             $('#issues-table-load-now-button').click();
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35600: 159994 | 160023 | 160085 | 160102