Bugzilla – Attachment 160061 Details for
Bug 28530
Allow configuration of floating limits by item type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28530: (QA follow-up): Fix qa issues
Bug-28530-QA-follow-up-Fix-qa-issues.patch (text/plain), 2.57 KB, created by
Kyle M Hall (khall)
on 2023-12-19 18:41:21 UTC
(
hide
)
Description:
Bug 28530: (QA follow-up): Fix qa issues
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2023-12-19 18:41:21 UTC
Size:
2.57 KB
patch
obsolete
>From 324b8a3f89fb9f3dd03301ab563bb80c1433f76e Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 19 Dec 2023 13:41:08 -0500 >Subject: [PATCH] Bug 28530: (QA follow-up): Fix qa issues > >--- > Koha/Library/FloatLimits.pm | 3 ++- > admin/float_limits.pl | 2 +- > koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc | 1 + > 3 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/Koha/Library/FloatLimits.pm b/Koha/Library/FloatLimits.pm >index ddeeb47afbe..a6eb4c43bac 100644 >--- a/Koha/Library/FloatLimits.pm >+++ b/Koha/Library/FloatLimits.pm >@@ -50,7 +50,8 @@ sub lowest_ratio_library { > LEFT JOIN items ON ( items.itype = library_float_limits.itemtype AND items.holdingbranch = library_float_limits.branchcode ) > LEFT JOIN biblioitems ON ( items.biblioitemnumber = biblioitems.biblioitemnumber ) > WHERE library_float_limits.itemtype = ? >- AND $field = ? >+ AND ( $field = ? OR $field IS NULL ) >+ AND library_float_limits.limit != 0 > GROUP BY branchcode > ORDER BY COUNT(items.holdingbranch)/library_float_limits.limit > }; >diff --git a/admin/float_limits.pl b/admin/float_limits.pl >index c07b24227d6..897e531d059 100755 >--- a/admin/float_limits.pl >+++ b/admin/float_limits.pl >@@ -65,7 +65,7 @@ if ( $op eq 'set_float_limits' ) { > limit => $limit > } > )->store() >- if $limit; # update or insert >+ if $limit ne q{}; # update or insert > } > } > $template->param( float_limits_updated => 1 ); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc >index c7caffc0143..71ecf63c6ba 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc >@@ -41,6 +41,7 @@ > [% IF ( CAN_user_parameters_manage_transfers ) %] > <li><a href="/cgi-bin/koha/admin/branch_transfer_limits.pl">Library transfer limits</a></li> > <li><a href="/cgi-bin/koha/admin/transport-cost-matrix.pl">Transport cost matrix</a></li> >+ <li><a href="/cgi-bin/koha/admin/float_limits.pl">Library float limits</a></li> > [% END %] > [% IF ( CAN_user_parameters_manage_item_circ_alerts ) %] > <li><a href="/cgi-bin/koha/admin/item_circulation_alerts.pl">Item circulation alerts</a></li> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28530
:
160038
|
160039
|
160040
|
160041
|
160042
|
160043
|
160044
|
160045
|
160046
|
160047
|
160048
|
160049
|
160050
|
160053
|
160054
|
160055
|
160056
|
160057
|
160058
|
160061
|
160062
|
160063
|
160064
|
160065
|
160066
|
160067
|
160068
|
160071
|
160072
|
160073
|
160074
|
160075
|
160076
|
160077
|
160078
|
160079
|
160080
|
160081
|
160082
|
160083
|
160084
|
163919
|
168343
|
168344
|
168345
|
168346
|
168347
|
168348
|
168349
|
168350