Bugzilla – Attachment 160084 Details for
Bug 28530
Allow configuration of floating limits by item type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28530: (QA follow-up) Require the item checkin to exceed the limit, rather than meet the limit
Bug-28530-QA-follow-up-Require-the-item-checkin-to.patch (text/plain), 1.12 KB, created by
ByWater Sandboxes
on 2023-12-19 19:38:44 UTC
(
hide
)
Description:
Bug 28530: (QA follow-up) Require the item checkin to exceed the limit, rather than meet the limit
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2023-12-19 19:38:44 UTC
Size:
1.12 KB
patch
obsolete
>From 1621ae98c768464f49eb2d362ae9ad6ab853cfd1 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 19 Dec 2023 14:15:03 -0500 >Subject: [PATCH] Bug 28530: (QA follow-up) Require the item checkin to exceed > the limit, rather than meet the limit > >Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index cd993e561a..5cb7db89ef 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2213,7 +2213,7 @@ sub AddReturn { > my $limit = Koha::Library::FloatLimits->find( { itemtype => $effective_itemtype, branchcode => $branch } ); > if ($limit) { > my $count = Koha::Items->count( { itype => $limit->itemtype } ); >- if ( $count >= $limit->float_limit ) { >+ if ( $count > $limit->float_limit ) { > my $transfer_branchcode = Koha::Library::FloatLimits->lowest_ratio_library( $item, $branch ); > if ( $transfer_branchcode ne $branch ) { > $returnbranch = $transfer_branchcode; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28530
:
160038
|
160039
|
160040
|
160041
|
160042
|
160043
|
160044
|
160045
|
160046
|
160047
|
160048
|
160049
|
160050
|
160053
|
160054
|
160055
|
160056
|
160057
|
160058
|
160061
|
160062
|
160063
|
160064
|
160065
|
160066
|
160067
|
160068
|
160071
|
160072
|
160073
|
160074
|
160075
|
160076
|
160077
|
160078
|
160079
|
160080
|
160081
|
160082
|
160083
|
160084
|
163919
|
168343
|
168344
|
168345
|
168346
|
168347
|
168348
|
168349
|
168350