Attachment 160131 Details for Bug 34950 – Bug 34950: Add availability statuses for in transit and on hold items.

[patch] Bug 34950: Add availability statuses for in transit and on hold items.

Bug-34950-Add-availability-statuses-for-in-transit.patch (text/plain), 2.42 KB, created by Brendan Lawlor on 2023-12-20 16:32:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Lawlor

Created: 2023-12-20 16:32:39 UTC

Size: 2.42 KB

patch

obsolete

>From 6c742a32fa0d22a243effc4d00e5c37d18953732 Mon Sep 17 00:00:00 2001
>From: Laura Escamilla <laura.escamilla@bywatersolutions.com>
>Date: Tue, 19 Dec 2023 18:31:54 +0000
>Subject: [PATCH] Bug 34950: Add availability statuses for in transit and on
> hold items.
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>To test:
>1. Enable the ILS-DI system preference.
>2. Place a hold for a patron and put it in transit. Place another hold for a patron that is available for pickup at the local branch. And then select an item that is available for checkout but donât change the status for it.
>3. Go to your testing OPAC and make an ILS-DI âGet Availabilityâ call using the item ids of the three items you worked with in step 2. (i.e. http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=321+323+214&id_type=item)
>4. Notice that the availability status for all three items is showing as available. The item in transit and the item with a local hold should have a status of not available and a message of why they are not available.
>5. Apply the patch
>6. Use restart_all.
>7. Refresh the page and notice that the statuses are now correct. The item in transit has a status of not available and an availability message of âIn transitâ. The item with the local hold has an availability status of not available with an availability message of âOn holdâ. Finally the available item is correctly showing up as available.
>8. Sign off and have a wonderful day. :)
>
>Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
>---
> C4/ILSDI/Services.pm | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm
>index f01dd34770..6f5aa2f2a5 100644
>--- a/C4/ILSDI/Services.pm
>+++ b/C4/ILSDI/Services.pm
>@@ -980,6 +980,10 @@ sub _availability {
>         return ( $biblionumber, __('not available'), __('Item withdrawn'), $location, $itemcallnumber );
>     } elsif ( $item->damaged ) {
>         return ( $biblionumber, __('not available'), __('Item damaged'), $location, $itemcallnumber );
>+    } elsif ( $item->get_transfer ) {
>+        return ( $biblionumber, __('not available'), __('In transit'), $location, $itemcallnumber );
>+    } elsif ( $item->current_holds->next ) {
>+        return ($biblionumber, __('not available'), __('On hold'), $location, $itemcallnumber );
>     } else {
>         return ( $biblionumber, __('available'), undef, $location, $itemcallnumber );
>     }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34950: 160060 | 160131 | 161029