Attachment 160139 Details for Bug 27113 – Bug 27113: Allow for ending special characters in titles

[patch] Bug 27113: Allow for ending special characters in titles

Bug-27113-Allow-for-ending-special-characters-in-t.patch (text/plain), 1.57 KB, created by Salah Ghedda on 2023-12-20 17:09:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Salah Ghedda

Created: 2023-12-20 17:09:32 UTC

Size: 1.57 KB

patch

obsolete

>From de496dfaace84a97e02e455af4f7ef1663c4eae3 Mon Sep 17 00:00:00 2001
>From: Blou <blou@inlibro.com>
>Date: Thu, 6 Oct 2022 14:25:36 -0400
>Subject: [PATCH] Bug 27113: Allow for ending special characters in titles
>
>Modifies the cleanup regex that removed )}' and " endings from the
>suggested titles or authors.  When selected without those, the record
>was not found.
>
>Ex: "MyTitle (1234)" became "MyTitle (123" in the list.  It returned no
>results, where the full title or "MyTitle 123" would.
>---
> .../bootstrap/js/opac-elasticsearch/opac-autocomplete.js        | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/opac-elasticsearch/opac-autocomplete.js b/koha-tmpl/opac-tmpl/bootstrap/js/opac-elasticsearch/opac-autocomplete.js
>index 065a76017b..0bcdb9dc82 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/js/opac-elasticsearch/opac-autocomplete.js
>+++ b/koha-tmpl/opac-tmpl/bootstrap/js/opac-elasticsearch/opac-autocomplete.js
>@@ -153,7 +153,7 @@ function autocomplete(inp, nb, left, right) {
>                     for (j = 0; j < tmp_data[i]['highlight'][pref[k] + '.' + key].length; j++){
>                         /* div with data for autocomplete */
>                         let tmp = tmp_data[i]['highlight'][pref[k] + '.' + key][j]
>-                        myset.add(tmp.replace(/[ &#,+()$~%.'":*?<{}!/;]+$/g, ''));
>+                        myset.add(tmp.replace(/[ &#,+($~%.:*?<{!/;]+$/g, ''));
>                         if (myset.size >= nb_autocomplete) break;
>                     };
>                     if (myset.size >= nb_autocomplete) break;
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 27113: 114168 | 114169 | 114945 | 115117 | 116293 | 119979 | 120028 | 120029 | 120084 | 120088 | 120109 | 120140 | 120141 | 120806 | 121497 | 121498 | 121555 | 121556 | 121557 | 121558 | 131207 | 131208 | 131209 | 131210 | 131211 | 132360 | 132361 | 132362 | 132363 | 132364 | 132808 | 132945 | 132946 | 133042 | 133045 | 133407 | 133409 | 133410 | 136312 | 136456 | 136457 | 136464 | 136465 | 136653 | 136657 | 136658 | 136659 | 136660 | 137436 | 137437 | 137438 | 137439 | 137780 | 137781 | 137782 | 137783 | 139624 | 141466 | 145167 | 146015 | 159769 | 159770 | 159771 | 159772 | 159773 | 159774 | 159775 | 160134 | 160135 | 160136 | 160137 | 160138 | 160139 | 160140 | 160141 | 160142 | 161076 | 161077 | 163826 | 165895 | 165896 | 165897 | 165898 | 165899 | 165900 | 165901 | 165902 | 165903 | 165904 | 165913 | 165922