Attachment 160168 Details for Bug 35619 – Bug 35619: Fix validation error alignment in change password form

[patch] Bug 35619: Fix validation error alignment in change password form

Bug-35619-Fix-validation-error-alignment-in-change.patch (text/plain), 2.55 KB, created by David Nind on 2023-12-20 21:19:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-12-20 21:19:03 UTC

Size: 2.55 KB

patch

obsolete

>From 886b0f95f0d2362918ef72c909ba76283f899710 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 20 Dec 2023 16:50:40 +0000
>Subject: [PATCH] Bug 35619: Fix validation error alignment in change password
> form
>
>Bug 31829 made a change to the change password form in the staff
>interface to accommodate a gap in the CSS following the staff interface
>redesign. This gap has been fixed, so we don't need a double class on
>the fieldset.
>
>With this change, the "hint" div can also be put back into place.
>
>To test, apply the patch and locate a patron record in the staff
>interface.
>
> - Click the "Change password" button on the patron detail page.
> - Confirm that the form layout looks correct.
> - Enter mismatched passwords in the "New password" and "Confirm new
>   password" fields and click "Save"
>   - The validation error message should be aligned to the right of the
>     input field.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../intranet-tmpl/prog/en/modules/members/member-password.tt  | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt
>index 92020ee74b..cd53549c69 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt
>@@ -85,7 +85,7 @@
> 	[% END %]
> 
> 
>-    <fieldset class="brief rows"><legend><h1>Change username and/or password for [% patron.firstname | html %] [% patron.surname | html %]</h1></legend>
>+    <fieldset class="rows"><legend><h1>Change username and/or password for [% patron.firstname | html %] [% patron.surname | html %]</h1></legend>
> 	<ol>
>     <li><label for="newuserid">New username:</label>
>     <input type="hidden" name="member" value="[% patron.borrowernumber | html %]" /><input type="text" id="newuserid" name="newuserid" size="20" value="[% patron.userid | html %]" /></li>
>@@ -100,9 +100,9 @@
>     <li>
>         <label for="newpassword2">Confirm new password:</label>
>         <input name="newpassword2"  id="newpassword2" type="password" size="20" autocomplete="new-password" />
>+        <div class="hint">Koha cannot display existing passwords. Leave the field blank to leave password unchanged.</div>
>     </li>
> 	</ol>
>-    <div class="hint">Koha cannot display existing passwords. Leave the field blank to leave password unchanged.</div>
> </fieldset>
>     <fieldset class="action">
>         <input type="hidden" name="csrf_token" value="[% csrf_token | html %]" />
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35619: 160132 | 160168 | 160222