Bugzilla – Attachment 160235 Details for
Bug 35579
marcrecord2csv searches authorised values inefficiently
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35579: Add unit test
Bug-35579-Add-unit-test.patch (text/plain), 1.57 KB, created by
Julian Maurice
on 2023-12-22 12:48:29 UTC
(
hide
)
Description:
Bug 35579: Add unit test
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2023-12-22 12:48:29 UTC
Size:
1.57 KB
patch
obsolete
>From b09273f19dbddf9cfa80629b7b793b13e3cb507f Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 18 Dec 2023 00:11:32 +0000 >Subject: [PATCH] Bug 35579: Add unit test > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > t/db_dependent/AuthorisedValues.t | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/AuthorisedValues.t b/t/db_dependent/AuthorisedValues.t >index a1bf7b48125..f4f57d1974a 100755 >--- a/t/db_dependent/AuthorisedValues.t >+++ b/t/db_dependent/AuthorisedValues.t >@@ -144,7 +144,7 @@ is_deeply( > ); > > subtest 'search_by_*_field + find_by_koha_field + get_description + authorised_values' => sub { >- plan tests => 6; >+ plan tests => 7; > > my $test_cat = Koha::AuthorisedValueCategories->find('TEST'); > $test_cat->delete if $test_cat; >@@ -252,6 +252,21 @@ subtest 'search_by_*_field + find_by_koha_field + get_description + authorised_v > ], > ); > }; >+ >+ subtest 'get_descriptions_by_marc_field' => sub { >+ plan tests => 1; >+ my $descriptions = Koha::AuthorisedValues->get_descriptions_by_marc_field( >+ { frameworkcode => '', tagfield => '952', tagsubfield => 'c' } ); >+ is_deeply( >+ $descriptions, >+ { >+ 'location_1' => 'location_1', >+ 'location_2' => 'location_2', >+ 'location_3' => 'location_3', >+ }, >+ ); >+ }; >+ > subtest 'authorised_values' => sub { > > plan tests => 2; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35579
:
159858
|
159936
|
159975
|
159976
|
160234
| 160235