Bugzilla – Attachment 160307 Details for
Bug 31297
Cannot add new subscription patterns from edit subscription page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31297: Allow null value for description in subscription_numberpatterns
Bug-31297-Allow-null-value-for-description-in-subs.patch (text/plain), 2.73 KB, created by
Martin Renvoize (ashimema)
on 2023-12-27 09:34:39 UTC
(
hide
)
Description:
Bug 31297: Allow null value for description in subscription_numberpatterns
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-12-27 09:34:39 UTC
Size:
2.73 KB
patch
obsolete
>From 6de53613c184dd0925560f2bff12ef463d66e89b Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 22 Dec 2023 14:52:04 +0000 >Subject: [PATCH] Bug 31297: Allow null value for description in > subscription_numberpatterns > >To test: >1 - Go to Serials >2 - Add a enw subscription >3 - Select Vendor and record, click next >4 - Select Numbring pattern: Number, or any to populate forms >4 - Click 'show advanced pattern' >5 - 'Modify pattern' >6 - Add a new name >7 - 'Save as new pattern' >8 - Nothin happens >9 - Check logs: > C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Field 'description' doesn't have a default value at /kohadevbox/koha/serials/create-numberpattern.pl line 58 >10 - Apply patch >11 - Update database >12 - Restart all >13 - Click save again >14 - Success! > >Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > ..._NULL_description_in_serial_numberpatterns.pl | 16 ++++++++++++++++ > installer/data/mysql/kohastructure.sql | 2 +- > 2 files changed, 17 insertions(+), 1 deletion(-) > create mode 100755 installer/data/mysql/atomicupdate/bug_31297_allow_NULL_description_in_serial_numberpatterns.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_31297_allow_NULL_description_in_serial_numberpatterns.pl b/installer/data/mysql/atomicupdate/bug_31297_allow_NULL_description_in_serial_numberpatterns.pl >new file mode 100755 >index 00000000000..911b318e9e1 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_31297_allow_NULL_description_in_serial_numberpatterns.pl >@@ -0,0 +1,16 @@ >+use Modern::Perl; >+ >+return { >+ bug_number => "31297", >+ description => "Allow subscription number pattern description to be NULL", >+ up => sub { >+ my ($args) = @_; >+ my ( $dbh, $out ) = @$args{qw(dbh out)}; >+ >+ $dbh->do("ALTER TABLE subscription_numberpatterns MODIFY description mediumtext DEFAULT NULL"); >+ >+ say $out "Added new table 'XXX'"; >+ say $out "Modified column 'subscription_numberpatterns.description' to allow and default to NULL"; >+ >+ }, >+}; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 0b59ad8d85c..16310f0f449 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -6018,7 +6018,7 @@ CREATE TABLE `subscription_numberpatterns` ( > `id` int(11) NOT NULL AUTO_INCREMENT, > `label` varchar(255) NOT NULL, > `displayorder` int(11) DEFAULT NULL, >- `description` mediumtext NOT NULL, >+ `description` mediumtext DEFAULT NULL, > `numberingmethod` varchar(255) NOT NULL, > `label1` varchar(255) DEFAULT NULL, > `add1` int(11) DEFAULT NULL, >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31297
:
138892
|
160244
|
160263
| 160307