Attachment 160327 Details for Bug 35651 – Bug 35651: Add check to make sure user has advanced_editor permission

[patch] Bug 35651: Add check to make sure user has advanced_editor permission

Bug-35651-Add-check-to-make-sure-user-has-advanced.patch (text/plain), 1.82 KB, created by ByWater Sandboxes on 2023-12-27 18:12:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2023-12-27 18:12:58 UTC

Size: 1.82 KB

patch

obsolete

>From 4583449a0fbff693b157e97bf36dfd117a1faee3 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Wed, 27 Dec 2023 17:52:57 +0000
>Subject: [PATCH] Bug 35651: Add check to make sure user has advanced_editor
> permission
>
>To test:
>1. Turn on the system preference 'EnableAdvancedCatalogingEditor'.
>2. Set up a staff user with permissions to editcatlouge but make sure "Use the advanced cataloging editor (requires edit_catalogue)" if OFF.
>3. Log in as that patron.
>4. Go to a record or create a new one in the basic editor and see the toggle advanced editor button.
>5. Try toggling it and you are logged out.
>6. APPLY PATCH
>7. Try 3 & 4 again, this time there should be no toggle button.
>8. Log in as a patron who does havbe the "Use the advanced cataloging editor (requires edit_catalogue)" permission on. They should be able to toggle between editors.
>
>Signed-off-by: Kelly <kelly@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt      | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index 3f09598fa1..83d34d3766 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -859,7 +859,7 @@ $(document).ready(function(){
>                     </div>
>                 [% END %]
> 
>-                [% IF Koha.Preference('EnableAdvancedCatalogingEditor') %]
>+                [% IF ( Koha.Preference('EnableAdvancedCatalogingEditor') && CAN_user_editcatalogue_advanced_editor ) %]
>                     <div id="toggle-editor">
>                         <label for="toggle-editor">Advanced editor: </label>
>                         <label class="switch">
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35651: 160326 | 160327 | 161051