Attachment 160348 Details for Bug 30070 – Bug 30070: (follow-up) Ensure strings are translatable

[patch] Bug 30070: (follow-up) Ensure strings are translatable

Bug-30070-follow-up-Ensure-strings-are-translatabl.patch (text/plain), 5.52 KB, created by Martin Renvoize (ashimema) on 2023-12-28 10:46:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-12-28 10:46:35 UTC

Size: 5.52 KB

patch

obsolete

>From 0a791af9c4fd0ce0e72fbbdb8b1cb536c50feb08 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 15 Nov 2023 09:27:28 +0000
>Subject: [PATCH] Bug 30070: (follow-up) Ensure strings are translatable
>
>Some strings moved from inline in templates to embedded in JS so we need
>to wrap them in _() now.
>
>Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../prog/en/modules/acqui/edifactmsgs.tt | 24 +++++++++----------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt
>index 6166f90fcd0..44d8a0a9e3b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt
>@@ -86,13 +86,13 @@
> "columns": [
> {
> "data": "type",
>- "title": "Type",
>+ "title": _("Type"),
> "searchable": true,
> "orderable": true
> },
> {
> "data": "transfer_date",
>- "title": "Transferred",
>+ "title": _("Transferred"),
> "searchable": true,
> "orderable": true,
> "render": function(data, type, row, meta) {
>@@ -101,13 +101,13 @@
> },
> {
> "data": "status",
>- "title": "Status",
>+ "title": _("Status"),
> "searchable": true,
> "orderable": true
> },
> {
> "data": "vendor.name",
>- "title": "Vendor",
>+ "title": _("Vendor"),
> "searchable": true,
> "orderable": true,
> "render": function(data, type, row, meta) {
>@@ -121,37 +121,37 @@
> }
> },
> {
>- "title": "Details",
>+ "title": _("Details"),
> "searchable": false,
> "orderable": false,
> "render": function(data, type, row, meta) {
> let rendered = '';
> if ( row.type == 'QUOTE' || row.type == 'ORDERS' ) {
> if ( row.basket_id ) {
>- rendered = '<a href="/cgi-bin/koha/acqui/basket.pl?basketno='+row.basket_id+'">Basket: '+row.basket_id+'</a>';
>+ rendered = '<a href="/cgi-bin/koha/acqui/basket.pl?basketno='+row.basked_id+'">'+_("Basket")+': '+row.basket_id+'</a>';
> }
> } else {
>- rendered = '<a href="/cgi-bin/koha/acqui/invoices.pl?message_id='+row.id+'&op=do_search">Invoices</a>';
>+ rendered = '<a href="/cgi-bin/koha/acqui/invoices.pl?message_id='+row.id+'&op=do_search">'+_("Invoices")+'</a>';
> }
> return rendered;
> }
> },
> {
> "data": "filename",
>- "title": "Filename",
>+ "title": _("Filename"),
> "searchable": true,
> "orderable": true
> },
> {
>- "title": "Actions",
>+ "title": _("Actions"),
> "className": "actions",
> "searchable": false,
> "orderable": false,
> "render": function(data, type, row, meta) {
>- var result = '<a class="btn btn-default btn-xs view_message" target="_blank" href="/cgi-bin/koha/acqui/edimsg.pl?id='+encodeURIComponent(row.id)+'"> View message</a> ';
>- result += '<a class="btn btn-default btn-xs delete_msg" href="/cgi-bin/koha/acqui/edifactmsgs.pl?op=delete&amp;message_id='+encodeURIComponent(row.id)+'"> Delete</a> ';
>+ var result = '<a class="btn btn-default btn-xs view_message" target="_blank" href="/cgi-bin/koha/acqui/edimsg.pl?id='+encodeURIComponent(row.id)+'"> '+_("View message")+'</a> ';
>+ result += '<a class="btn btn-default btn-xs delete_msg" href="/cgi-bin/koha/acqui/edifactmsgs.pl?op=delete&amp;message_id='+encodeURIComponent(row.id)+'"> '+_("Delete")+'</a> ';
> if ( row.status == 'new' ) {
>- result += '<a class="btn btn-default btn-xs import_msg" href="/cgi-bin/koha/acqui/edifactmsgs.pl?op=import&amp;message_id='+encodeURIComponent(row.id)+'"> Import</a> ';
>+ result += '<a class="btn btn-default btn-xs import_msg" href="/cgi-bin/koha/acqui/edifactmsgs.pl?op=import&amp;message_id='+encodeURIComponent(row.id)+'"> '+_("Import")+'</a> ';
> }
> return result;
> }
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 30070: 158808 | 158809 | 158810 | 158887 | 158903 | 158904 | 158905 | 158906 | 158907 | 158908 | 158909 | 158910 | 158911 | 158912 | 158913 | 158914 | 158915 | 158918 | 158920 | 158922 | 158923 | 158924 | 158925 | 158926 | 158927 | 158928 | 158929 | 158930 | 158931 | 158932 | 158933 | 158934 | 158935 | 158936 | 158937 | 158938 | 158939 | 158940 | 158941 | 158942 | 158943 | 158944 | 158945 | 158946 | 158947 | 158948 | 158949 | 158950 | 158951 | 158952 | 158953 | 158954 | 158955 | 158963 | 158964 | 158965 | 158966 | 158967 | 158968 | 158969 | 158970 | 158971 | 158972 | 158973 | 158974 | 158975 | 159026 | 159027 | 159028 | 159029 | 159030 | 159031 | 159032 | 159033 | 159034 | 159035 | 159036 | 160336 | 160337 | 160338 | 160339 | 160340 | 160341 | 160342 | 160343 | 160344 | 160345 | 160346 | 160347 | 160348