Attachment 160352 Details for Bug 35398 – Bug 35398: Fix LRP support for EDI orders with single items

[patch] Bug 35398: Fix LRP support for EDI orders with single items

Bug-35398-Fix-LRP-support-for-EDI-orders-with-sing.patch (text/plain), 1.49 KB, created by Martin Renvoize (ashimema) on 2023-12-28 12:03:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-12-28 12:03:05 UTC

Size: 1.49 KB

patch

obsolete

>From 480b1f467aa5796d4428601f5494c32a671837ff Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 24 Nov 2023 13:06:37 +0000
>Subject: [PATCH] Bug 35398: Fix LRP support for EDI orders with single items
>
>This patch corrects a mistake in the original implementaiton of bug
>20595 where we introduced support for the LRP segments being used to
>automatically assign items ordered via EDI to stock rotation plans.
>
>Signed-off-by: Sophie Halden <sophie.halden@cheshiresharedservices.gov.uk>
>---
> Koha/EDI.pm | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
>diff --git a/Koha/EDI.pm b/Koha/EDI.pm
>index ceb9a2ccd41..0c71f50ede0 100644
>--- a/Koha/EDI.pm
>+++ b/Koha/EDI.pm
>@@ -829,6 +829,22 @@ sub quote_item {
>                     }
>                 );
>                 ++$created;
>+
>+                my $lrp =
>+                  $item->girfield( 'library_rotation_plan' );
>+                if ($lrp) {
>+                    my $rota =
>+                      Koha::StockRotationRotas->find( { title => $lrp },
>+                        { key => 'stockrotationrotas_title' } );
>+                    if ($rota) {
>+                        $rota->add_item($itemnumber);
>+                        $logger->trace("Item added to rota $rota->id");
>+                    }
>+                    else {
>+                        $logger->error(
>+                            "No rota found matching $lrp in orderline");
>+                    }
>+                }
>             }
>         }
>     }
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 35398: 159240 | 160350 | 160352 | 160406 | 160407 | 162541 | 162542 | 162543 | 162544