Bugzilla – Attachment 160363 Details for
Bug 31376
Input type email in system preferences prevents multiple addresses
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31376: Attempt to allow comma delimeted list of emails for preferences
Bug-31376-Attempt-to-allow-comma-delimeted-list-of.patch (text/plain), 3.80 KB, created by
Martin Renvoize (ashimema)
on 2023-12-29 09:21:01 UTC
(
hide
)
Description:
Bug 31376: Attempt to allow comma delimeted list of emails for preferences
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-12-29 09:21:01 UTC
Size:
3.80 KB
patch
obsolete
>From 024241821ee53eee3e0baad0713d430c888d7ef4 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 29 Dec 2023 09:19:48 +0000 >Subject: [PATCH] Bug 31376: Attempt to allow comma delimeted list of emails > for preferences > >This doesn't work in chrome in my testing.. but I'm not entirely sure >why. > >I even tried commenting out the jQuery validator lines introduced in bug >8000, but that didn't help either. >--- > admin/preferences.pl | 3 +++ > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 2 +- > .../prog/en/modules/admin/preferences/circulation.pref | 1 + > 3 files changed, 5 insertions(+), 1 deletion(-) > >diff --git a/admin/preferences.pl b/admin/preferences.pl >index 108aaf41d1a..b3e69b94496 100755 >--- a/admin/preferences.pl >+++ b/admin/preferences.pl >@@ -77,6 +77,9 @@ sub _get_chunk { > $chunk->{'input_type'} = 'password'; > } elsif ( $options{'class'} && $options{'class'} eq 'email' ) { > $chunk->{'input_type'} = 'email'; >+ if ( $options{'multiple'} ) { >+ $chunk->{'multiple'} = 1; >+ } > } elsif ( $options{'class'} && $options{'class'} eq 'date' ) { > $chunk->{'dateinput'} = 1; > } elsif ( $options{'type'} && ( $options{'type'} eq 'opac-languages' || $options{'type'} eq 'staff-languages' ) ) { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >index deaaadb9826..54cb4f7ba76 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >@@ -116,7 +116,7 @@ > [% IF CHUNK.name == 'UsageStatsGeolocation' %] > <input type="[%IF CHUNK.input_type %][% CHUNK.input_type | html %][% ELSE %]text[% END %]" name="pref_[% CHUNK.name | html %]" id="pref_[% CHUNK.name | html %]" class="preference preference-[% CHUNK.class or "short" | html %]" value="[% CHUNK.value | html %]" autocomplete="off" readonly="readonly" size="40" style="width: auto;"/> [% IF ( CHUNK.dateinput ) %]<span class="hint">[% INCLUDE 'date-format.inc' %]</span>[% END %] > [% ELSE %] >- <input type="[%IF CHUNK.input_type %][% CHUNK.input_type | html %][% ELSE %]text[% END %]" name="pref_[% CHUNK.name | html %]" id="pref_[% CHUNK.name | html %]" class="preference preference-[% CHUNK.class or "short" | html %]" value="[% CHUNK.value | html %]" autocomplete="off" /> [% IF ( CHUNK.dateinput ) %]<span class="hint">[% INCLUDE 'date-format.inc' %]</span>[% END %] >+ <input type="[%IF CHUNK.input_type %][% CHUNK.input_type | html %][% ELSE %]text[% END %]" name="pref_[% CHUNK.name | html %]" id="pref_[% CHUNK.name | html %]" class="preference preference-[% CHUNK.class or "short" | html %]" value="[% CHUNK.value | html %]" autocomplete="off" [% IF CHUNK.multiple %]multiple[% END %] /> [% IF ( CHUNK.dateinput ) %]<span class="hint">[% INCLUDE 'date-format.inc' %]</span>[% END %] > [% END %] > [% ELSIF ( CHUNK.type_select ) %] > [% IF CHUNK.disabled %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 40f2d65a81e..97630fd433b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -384,6 +384,7 @@ Circulation: > - "Send all notices as a BCC to this email address:" > - pref: NoticeBcc > class: email >+ multiple: true > - > - pref: OverdueNoticeCalendar > choices: >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31376
: 160363