Attachment 160403 Details for Bug 35539 – Bug 35539: Remove 'issuelimit' column/field from categories table

[patch] Bug 35539: Remove 'issuelimit' column/field from categories table

Bug-35539-Remove-issuelimit-columnfield-from-categ.patch (text/plain), 7.21 KB, created by Pedro Amorim on 2024-01-02 12:49:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-01-02 12:49:38 UTC

Size: 7.21 KB

patch

obsolete

>From 34792947c61c94b43443868c1b3cb7fb94f262be Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Tue, 2 Jan 2024 12:32:07 +0000
>Subject: [PATCH] Bug 35539: Remove 'issuelimit' column/field from categories
> table
>
>---
> Koha/Patron/Category.pm                            |  1 -
> .../data/mysql/en/optional/patron_categories.yml   | 12 ------------
> installer/data/mysql/kohastructure.sql             |  1 -
> t/db_dependent/Circulation/GetHardDueDate.t        | 14 ++++++--------
> 4 files changed, 6 insertions(+), 22 deletions(-)
>
>diff --git a/Koha/Patron/Category.pm b/Koha/Patron/Category.pm
>index 461baa973a..3632564552 100644
>--- a/Koha/Patron/Category.pm
>+++ b/Koha/Patron/Category.pm
>@@ -247,7 +247,6 @@ sub to_api_mapping {
>         dateofbirthrequired               => 'lower_age_limit',
>         enrolmentfee                      => 'enrolment_fee',
>         overduenoticerequired             => 'overdue_notice_required',
>-        issuelimit                        => undef,                                 # Unused
>         reservefee                        => 'reserve_fee',
>         hidelostitems                     => 'hide_lost_items',
>         category_type                     => 'category_type',
>diff --git a/installer/data/mysql/en/optional/patron_categories.yml b/installer/data/mysql/en/optional/patron_categories.yml
>index 488ee9e3c4..2d4038c689 100644
>--- a/installer/data/mysql/en/optional/patron_categories.yml
>+++ b/installer/data/mysql/en/optional/patron_categories.yml
>@@ -54,7 +54,6 @@ tables:
>           dateofbirthrequired: 18
>           enrolmentfee: '0.000000'
>           overduenoticerequired: 1
>-          issuelimit: ~
>           reservefee: '0.000000'
>           category_type: 'A'
>           can_be_guarantee: 0
>@@ -66,7 +65,6 @@ tables:
>           dateofbirthrequired: 18
>           enrolmentfee: '0.000000'
>           overduenoticerequired: 1
>-          issuelimit: ~
>           reservefee: '0.000000'
>           category_type: 'A'
>           can_be_guarantee: 0
>@@ -78,7 +76,6 @@ tables:
>           dateofbirthrequired: 18
>           enrolmentfee: '0.000000'
>           overduenoticerequired: 1
>-          issuelimit: ~
>           reservefee: '0.000000'
>           category_type: 'A'
>           can_be_guarantee: 0
>@@ -91,7 +88,6 @@ tables:
>           dateofbirthrequired: 5
>           enrolmentfee: '0.000000'
>           overduenoticerequired: 1
>-          issuelimit: ~
>           reservefee: '0.000000'
>           category_type: 'C'
>           can_be_guarantee: 1
>@@ -103,7 +99,6 @@ tables:
>           dateofbirthrequired: 5
>           enrolmentfee: '0.000000'
>           overduenoticerequired: 1
>-          issuelimit: ~
>           reservefee: '0.000000'
>           category_type: 'C'
>           can_be_guarantee: 1
>@@ -115,7 +110,6 @@ tables:
>           dateofbirthrequired: 5
>           enrolmentfee: '0.000000'
>           overduenoticerequired: 1
>-          issuelimit: ~
>           reservefee: '0.000000'
>           category_type: 'C'
>           can_be_guarantee: 1
>@@ -128,7 +122,6 @@ tables:
>           dateofbirthrequired: 18
>           enrolmentfee: '0.000000'
>           overduenoticerequired: 0
>-          issuelimit: ~
>           reservefee: '0.000000'
>           category_type: 'P'
>           can_be_guarantee: 1
>@@ -140,7 +133,6 @@ tables:
>           dateofbirthrequired: 5
>           enrolmentfee: '0.000000'
>           overduenoticerequired: 1
>-          issuelimit: ~
>           reservefee: '0.000000'
>           category_type: 'P'
>           can_be_guarantee: 1
>@@ -153,7 +145,6 @@ tables:
>           dateofbirthrequired: 18
>           enrolmentfee: '0.000000'
>           overduenoticerequired: 1
>-          issuelimit: ~
>           reservefee: '0.000000'
>           category_type: 'I'
>           can_be_guarantee: 0
>@@ -165,7 +156,6 @@ tables:
>           dateofbirthrequired: 18
>           enrolmentfee: '0.000000'
>           overduenoticerequired: 1
>-          issuelimit: ~
>           reservefee: '0.000000'
>           category_type: 'I'
>           can_be_guarantee: 0
>@@ -177,7 +167,6 @@ tables:
>           dateofbirthrequired: 18
>           enrolmentfee: '0.000000'
>           overduenoticerequired: 1
>-          issuelimit: ~
>           reservefee: '0.000000'
>           category_type: 'I'
>           can_be_guarantee: 0
>@@ -190,7 +179,6 @@ tables:
>           dateofbirthrequired: 18
>           enrolmentfee: '0.000000'
>           overduenoticerequired: 0
>-          issuelimit: ~
>           reservefee: '0.000000'
>           category_type: 'S'
>           can_be_guarantee: 0
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 9b5ae37672..b694a819c9 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -1781,7 +1781,6 @@ CREATE TABLE `categories` (
>   `dateofbirthrequired` tinyint(1) DEFAULT NULL COMMENT 'the minimum age required for the patron category',
>   `enrolmentfee` decimal(28,6) DEFAULT NULL COMMENT 'enrollment fee for the patron',
>   `overduenoticerequired` tinyint(1) DEFAULT NULL COMMENT 'are overdue notices sent to this patron category (1 for yes, 0 for no)',
>-  `issuelimit` smallint(6) DEFAULT NULL COMMENT 'unused in Koha',
>   `reservefee` decimal(28,6) DEFAULT NULL COMMENT 'cost to place holds',
>   `hidelostitems` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'are lost items shown to this category (1 for yes, 0 for no)',
>   `category_type` varchar(1) NOT NULL DEFAULT 'A' COMMENT 'type of Koha patron (Adult, Child, Professional, Organizational, Statistical, Staff)',
>diff --git a/t/db_dependent/Circulation/GetHardDueDate.t b/t/db_dependent/Circulation/GetHardDueDate.t
>index 8a24c64f5c..227bde390c 100755
>--- a/t/db_dependent/Circulation/GetHardDueDate.t
>+++ b/t/db_dependent/Circulation/GetHardDueDate.t
>@@ -81,21 +81,19 @@ my $samplecat = {
>     dateofbirthrequired   => undef,
>     enrolmentfee          => undef,
>     overduenoticerequired => undef,
>-    issuelimit            => undef,
>     reservefee            => undef,
>     hidelostitems         => 0,
>     category_type         => 'A',
> };
> my $query =
>-"INSERT INTO categories (categorycode,description,enrolmentperiod,enrolmentperioddate,dateofbirthrequired,enrolmentfee,overduenoticerequired,issuelimit ,reservefee ,hidelostitems ,category_type) VALUES( ?,?,?,?,?,?,?,?,?,?,?)";
>+"INSERT INTO categories (categorycode,description,enrolmentperiod,enrolmentperioddate,dateofbirthrequired,enrolmentfee,overduenoticerequired ,reservefee ,hidelostitems ,category_type) VALUES( ?,?,?,?,?,?,?,?,?,?)";
> $dbh->do(
>     $query, {},
>-    $samplecat->{categorycode},        $samplecat->{description},
>-    $samplecat->{enrolmentperiod},     $samplecat->{enrolmentperioddate},
>-    $samplecat->{dateofbirthrequired}, $samplecat->{enrolmentfee},
>-    $samplecat->{overduenoticerequired}, $samplecat->{issuelimit},
>-    $samplecat->{reservefee}, $samplecat->{hidelostitems},
>-    $samplecat->{category_type}
>+    $samplecat->{categorycode},          $samplecat->{description},
>+    $samplecat->{enrolmentperiod},       $samplecat->{enrolmentperioddate},
>+    $samplecat->{dateofbirthrequired},   $samplecat->{enrolmentfee},
>+    $samplecat->{overduenoticerequired}, $samplecat->{reservefee},
>+    $samplecat->{hidelostitems},         $samplecat->{category_type}
> );
> 
> my $builder = t::lib::TestBuilder->new;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35539: 160400 | 160401 | 160402 | 160403 | 160404 | 160413 | 160414 | 160415 | 160416 | 160417 | 160446 | 165724 | 169209 | 169210 | 169211 | 169212 | 169213 | 169214