Attachment 160407 Details for Bug 35398 – Bug 35398: (QA follow-up) Tidy code

[patch] Bug 35398: (QA follow-up) Tidy code

Bug-35398-QA-follow-up-Tidy-code.patch (text/plain), 1.58 KB, created by Kyle M Hall (khall) on 2024-01-02 14:11:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-01-02 14:11:51 UTC

Size: 1.58 KB

patch

obsolete

>From 9c4970a8d410c37d49a8ddc3d09b62aa45e3869a Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 2 Jan 2024 08:58:04 -0500
>Subject: [PATCH] Bug 35398: (QA follow-up) Tidy code
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/EDI.pm | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
>diff --git a/Koha/EDI.pm b/Koha/EDI.pm
>index 0c71f50ede0..ad7ea7a075b 100644
>--- a/Koha/EDI.pm
>+++ b/Koha/EDI.pm
>@@ -830,19 +830,17 @@ sub quote_item {
>                 );
>                 ++$created;
> 
>-                my $lrp =
>-                  $item->girfield( 'library_rotation_plan' );
>+                my $lrp = $item->girfield('library_rotation_plan');
>                 if ($lrp) {
>-                    my $rota =
>-                      Koha::StockRotationRotas->find( { title => $lrp },
>-                        { key => 'stockrotationrotas_title' } );
>+                    my $rota = Koha::StockRotationRotas->find(
>+                        { title => $lrp },
>+                        { key   => 'stockrotationrotas_title' }
>+                    );
>                     if ($rota) {
>                         $rota->add_item($itemnumber);
>                         $logger->trace("Item added to rota $rota->id");
>-                    }
>-                    else {
>-                        $logger->error(
>-                            "No rota found matching $lrp in orderline");
>+                    } else {
>+                        $logger->error("No rota found matching $lrp in orderline");
>                     }
>                 }
>             }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35398: 159240 | 160350 | 160352 | 160406 | 160407 | 162541 | 162542 | 162543 | 162544