Bugzilla – Attachment 160430 Details for
Bug 35581
ILL Koha classes are not consistent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35581: Koha/Illrequest/SupplierUpdate.pm -> Koha/ILL/Request/SupplierUpdate.pm
Bug-35581-KohaIllrequestSupplierUpdatepm---KohaILL.patch (text/plain), 5.65 KB, created by
David Nind
on 2024-01-02 19:10:58 UTC
(
hide
)
Description:
Bug 35581: Koha/Illrequest/SupplierUpdate.pm -> Koha/ILL/Request/SupplierUpdate.pm
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-01-02 19:10:58 UTC
Size:
5.65 KB
patch
obsolete
>From d50a079c22031849682c681dfcfc3df29ffbdf3c Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Thu, 14 Dec 2023 17:24:50 +0000 >Subject: [PATCH] Bug 35581: Koha/Illrequest/SupplierUpdate.pm -> > Koha/ILL/Request/SupplierUpdate.pm > >Koha/Illrequest/SupplierUpdateProcessor.pm -> Koha/ILL/Request/SupplierUpdateProcessor.pm > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/{Illrequest => ILL/Request}/SupplierUpdate.pm | 12 ++++++------ > .../Request}/SupplierUpdateProcessor.pm | 2 +- > Koha/Illrequest.pm | 2 +- > misc/process_ill_updates.pl | 2 +- > t/db_dependent/Illrequest/SupplierUpdate.t | 10 +++++----- > t/db_dependent/Illrequests.t | 2 +- > 6 files changed, 15 insertions(+), 15 deletions(-) > rename Koha/{Illrequest => ILL/Request}/SupplierUpdate.pm (85%) > rename Koha/{Illrequest => ILL/Request}/SupplierUpdateProcessor.pm (97%) > >diff --git a/Koha/Illrequest/SupplierUpdate.pm b/Koha/ILL/Request/SupplierUpdate.pm >similarity index 85% >rename from Koha/Illrequest/SupplierUpdate.pm >rename to Koha/ILL/Request/SupplierUpdate.pm >index 3cc54298fc..e966b02e01 100644 >--- a/Koha/Illrequest/SupplierUpdate.pm >+++ b/Koha/ILL/Request/SupplierUpdate.pm >@@ -1,4 +1,4 @@ >-package Koha::Illrequest::SupplierUpdate; >+package Koha::ILL::Request::SupplierUpdate; > > # Copyright 2022 PTFS Europe Ltd > # >@@ -21,7 +21,7 @@ use Modern::Perl; > > =head1 NAME > >-Koha::Illrequest::SupplierUpdate - Represents a single request update from a supplier >+Koha::ILL::Request::SupplierUpdate - Represents a single request update from a supplier > > =head1 SYNOPSIS > >@@ -39,13 +39,13 @@ an update from a supplier > > =head3 new > >- my $update = Koha::Illrequest::SupplierUpdate->new( >+ my $update = Koha::ILL::Request::SupplierUpdate->new( > $source_type, > $source_name, > $update > ); > >-Create a new Koha::Illrequest::SupplierUpdate object. >+Create a new Koha::ILL::Request::SupplierUpdate object . > > =cut > >@@ -66,7 +66,7 @@ sub new { > > =head3 attach_processor > >- Koha::Illrequest::SupplierUpdate->attach_processor($processor); >+ Koha::ILL::Request::SupplierUpdate->attach_processor($processor); > > Pushes a processor function onto the 'processors' arrayref > >@@ -79,7 +79,7 @@ sub attach_processor { > > =head3 run_processors > >- Koha::Illrequest::SupplierUpdate->run_processors(); >+ Koha::ILL::Request::SupplierUpdate->run_processors(); > > Iterates all processors on this object and runs each > >diff --git a/Koha/Illrequest/SupplierUpdateProcessor.pm b/Koha/ILL/Request/SupplierUpdateProcessor.pm >similarity index 97% >rename from Koha/Illrequest/SupplierUpdateProcessor.pm >rename to Koha/ILL/Request/SupplierUpdateProcessor.pm >index 3136127c83..9ce0d9163b 100644 >--- a/Koha/Illrequest/SupplierUpdateProcessor.pm >+++ b/Koha/ILL/Request/SupplierUpdateProcessor.pm >@@ -1,4 +1,4 @@ >-package Koha::Illrequest::SupplierUpdateProcessor; >+package Koha::ILL::Request::SupplierUpdateProcessor; > > # Copyright 2022 PTFS Europe Ltd > # >diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm >index bd2be794fd..28ec6d635a 100644 >--- a/Koha/Illrequest.pm >+++ b/Koha/Illrequest.pm >@@ -1813,7 +1813,7 @@ sub get_notice { > > =head3 attach_processors > >-Receive a Koha::Illrequest::SupplierUpdate and attach >+Receive a Koha::ILL::Request::SupplierUpdate and attach > any processors we have for it > > =cut >diff --git a/misc/process_ill_updates.pl b/misc/process_ill_updates.pl >index fb2e22544c..3acba3d47f 100755 >--- a/misc/process_ill_updates.pl >+++ b/misc/process_ill_updates.pl >@@ -129,7 +129,7 @@ while (my $request = $requests->next) { > # process it > # > # Since each backend's update format is different, it may >- # be necessary for a backend to subclass Koha::Illrequest::SupplierUpdate >+ # be necessary for a backend to subclass Koha::ILL::Request::SupplierUpdate > # so it can provide methods (corresponding to a generic interface) that > # return pertinent info to core ILL when it is processing updates > # >diff --git a/t/db_dependent/Illrequest/SupplierUpdate.t b/t/db_dependent/Illrequest/SupplierUpdate.t >index 72d2fc280e..281c1df5f4 100755 >--- a/t/db_dependent/Illrequest/SupplierUpdate.t >+++ b/t/db_dependent/Illrequest/SupplierUpdate.t >@@ -20,22 +20,22 @@ use Modern::Perl; > use Test::MockObject; > > use Koha::Illrequest; >-use Koha::Illrequest::SupplierUpdate; >+use Koha::ILL::Request::SupplierUpdate; > > use Test::More tests => 4; > >-use_ok('Koha::Illrequest::SupplierUpdate'); >+use_ok('Koha::ILL::Request::SupplierUpdate'); > >-my $update = Koha::Illrequest::SupplierUpdate->new( >+my $update = Koha::ILL::Request::SupplierUpdate->new( > 'test_type', > 'test_name', > 'Arbitrary update text' > ); > >-isa_ok( $update, 'Koha::Illrequest::SupplierUpdate' ); >+isa_ok( $update, 'Koha::ILL::Request::SupplierUpdate' ); > > my $processor = Test::MockObject->new; >-$processor->set_isa('Koha::Illrequest::Processor'); >+$processor->set_isa('Koha::ILL::Request::Processor'); > $processor->{name} = 'Test processor'; > $processor->mock('run', sub { > my ( $self, $update, $options, $result ) = @_; >diff --git a/t/db_dependent/Illrequests.t b/t/db_dependent/Illrequests.t >index 538a24c11b..48128f9960 100755 >--- a/t/db_dependent/Illrequests.t >+++ b/t/db_dependent/Illrequests.t >@@ -952,7 +952,7 @@ subtest 'Helpers' => sub { > my $type = 'test_type_1'; > my $name = 'test_name_1'; > my $update = Test::MockObject->new; >- $update->set_isa('Koha::Illrequest::SupplierUpdate'); >+ $update->set_isa('Koha::ILL::Request::SupplierUpdate'); > $update->{source_type} = $type; > $update->{source_name} = $name; > $update->{processors} = []; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35581
:
159863
|
159864
|
159865
|
159866
|
159867
|
159868
|
159869
|
159870
|
159871
|
159872
|
159873
|
160422
|
160423
|
160424
|
160425
|
160426
|
160427
|
160428
|
160429
|
160430
|
160431
|
160432
|
160620
|
160622
|
162020
|
162021
|
162022
|
162023
|
162024
|
162025
|
162026
|
162027
|
162028
|
162029
|
162030
|
162031
|
162032
|
162817
|
162818
|
162819
|
162820
|
162821
|
162822
|
162823
|
162824
|
162825
|
162826
|
162827
|
162828
|
162829
|
162880
|
162881
|
162882
|
162883
|
162884
|
162885
|
162886
|
162887
|
162888
|
162889
|
162890
|
162891
|
162892
|
163803
|
163804
|
163805
|
163806
|
163807
|
163808
|
163809
|
163810
|
163811
|
163812
|
163813
|
163814
|
163815
|
163816
|
164069
|
164070
|
164071
|
164072
|
164073
|
164074
|
164075
|
164076
|
164077
|
164078
|
164079
|
164080
|
164081
|
164082
|
165448