Attachment 16049 Details for Bug 9772 – [SIGNED-OFF] Bug 9772 - Display Norwegian chars correctly in the patron category dropdown

[patch] [SIGNED-OFF] Bug 9772 - Display Norwegian chars correctly in the patron category dropdown

SIGNED-OFF-Bug-9772---Display-Norwegian-chars-corr.patch (text/plain), 2.83 KB, created by Owen Leonard on 2013-03-11 18:32:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2013-03-11 18:32:05 UTC

Size: 2.83 KB

patch

obsolete

>From 5906be1b2abed1ced44b6f281e0f2025a1581b51 Mon Sep 17 00:00:00 2001
>From: Magnus Enger <magnus@enger.priv.no>
>Date: Fri, 8 Mar 2013 17:12:33 +0100
>Subject: [PATCH] [SIGNED-OFF] Bug 9772 - Display Norwegian chars correctly in
> the patron category dropdown
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>Content-Type: text/plain; charset="utf-8"
>
>To reproduce:
>- Install Norwegian translation
>- Run through the web installer in Norwegian, and make sure you choose
>  the optionl ("2-Valgfritt") patron_categories.sql data
>- Log in and visit the "Patrons" page
>- The dropdown should contain black diamonds with question marks instead
>  of the Norwegian chars Ã¦Ã¸Ã¥
>
>To test
>- Apply the patch to the situation above
>- Check the dropdown again - Ã¦Ã¸Ã¥ should be displayed
>- If you want to check with other interface languages than Norwegian,
>  remember to re-install the nb-NO translation after the patch has been
>  applied
>
>This feels slightly like curing the symptom instead of the disease,
>alternative patches are welcome!
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>I agree that this doesn't seem like a broad enough solution, but it
>doesn't do any harm to apply an incomplete fix as long as the underlying
>problem can be followed up on. Note that this problem isn't specific to
>Norwegian, but doesn't happen with all non-basic characters.
>---
> .../prog/en/includes/patron-toolbar.inc            |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc
>index 374d388..8d36da3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc
>@@ -4,7 +4,7 @@
>         <button class="btn btn-small dropdown-toggle" data-toggle="dropdown"><i class="icon-plus"></i> New patron <span class="caret"></span></button>
>             <ul class="dropdown-menu">
>                 [% IF ( AddPatronLists_categorycode ) %]
>-                    [% FOREACH categorie IN categories %]<li><a href="/cgi-bin/koha/members/memberentry.pl?op=add&amp;categorycode=[% categorie.categorycode %]">[% categorie.description %]</a></li>[% END %]
>+                    [% FOREACH categorie IN categories %]<li><a href="/cgi-bin/koha/members/memberentry.pl?op=add&amp;categorycode=[% categorie.categorycode %]">[% categorie.description | html_entity %]</a></li>[% END %]
>                 [% ELSE %]
>                     <li><a href="/cgi-bin/koha/members/memberentry.pl?op=add&amp;category_type=A">Adult patron</a></li>
>                     <li><a href="/cgi-bin/koha/members/memberentry.pl?op=add&amp;category_type=C">Child patron</a></li>
>@@ -16,4 +16,4 @@
>             </ul>
>     </div>
> </div>
>-[% END %]
>\ No newline at end of file
>+[% END %]
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9772: 15987 | 16049 | 16490