Attachment 16050 Details for Bug 9756 – [SIGNED-OFF] Bug 9756 - Patron self registration missing preference PatronSelfRegistrationAdditionalInstructions

[patch] [SIGNED-OFF] Bug 9756 - Patron self registration missing preference PatronSelfRegistrationAdditionalInstructions

SIGNED-OFF-Bug-9756---Patron-self-registration-mis.patch (text/plain), 3.74 KB, created by Owen Leonard on 2013-03-11 18:58:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2013-03-11 18:58:51 UTC

Size: 3.74 KB

patch

obsolete

>From f60f5e7341d8c2786624279d3da9404378e93f36 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 6 Mar 2013 11:31:56 -0500
>Subject: [PATCH] [SIGNED-OFF] Bug 9756 - Patron self registration missing
> preference PatronSelfRegistrationAdditionalInstructions
>Content-Type: text/plain; charset="utf-8"
>
>The patron self registration system references a system preference
>PatronSelfRegistrationAdditionalInstructions as a free text field
>to add additional instructions for newly self registered patrons,
>but the system preference in neither created in the database,
>nor exposed via the staff interface.
>
>Test Plan:
>1) Apply patch
>2) Run updatedatabase.pl
>3) Add some text to the new system preference
>   PatronSelfRegistrationAdditionalInstructions
>4) Enable opac self registrations and complete a self registration
>5) Note the additional instructions you entered appear on the
>   "registration complete" page
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> installer/data/mysql/sysprefs.sql                  |    1 +
> installer/data/mysql/updatedatabase.pl             |    7 +++++++
> .../prog/en/modules/admin/preferences/opac.pref    |    5 +++++
> 3 files changed, 13 insertions(+)
>
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index cad409c..9c66df0 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -418,3 +418,4 @@ INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('
> INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES('Persona',0,'Use Mozilla Persona for login','','YesNo');
> INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('OpacItemLocation','callnum','Show the shelving location of items in the opac','callnum|ccode|location','Choice');
> INSERT INTO systempreferences (variable,value,explanation,options,type)  VALUES('TrackClicks','0','Track links clicked',NULL,'Integer');
>+INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES('PatronSelfRegistrationAdditionalInstructions','','A free text field to display additional instructions to newly self registered patrons.','','free');
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 041040a..a93fa5a 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -6477,6 +6477,13 @@ if ( CheckVersion($DBversion) ) {
> }
> 
> 
>+$DBversion = "3.11.00.XXX";
>+if ( CheckVersion($DBversion) ) {
>+    $dbh->do("INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('PatronSelfRegistrationAdditionalInstructions', '', NULL , 'A free text field to display additional instructions to newly self registered patrons.', 'free'    );");
>+    print "Upgrade to $DBversion done (Bug 9756 - Patron self registration missing the system preference PatronSelfRegistrationAdditionalInstructions)\n";
>+    SetVersion($DBversion);
>+}
>+
> =head1 FUNCTIONS
> 
> =head2 TableExists($table)
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index 57df512..c7b0414 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -596,3 +596,8 @@ OPAC:
>             - pref: PatronSelfRegistrationBorrowerUnwantedField
>               class: multi
>             - (separate columns with |)
>+        -
>+            - "Display the following additional instructions for patrons who self register via the OPAC ( HTML is allowed ):"
>+            - pref: PatronSelfRegistrationAdditionalInstructions
>+              type: textarea
>+              class: html
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9756: 15911 | 16050 | 16059