Attachment 160501 Details for Bug 35692 – Bug 35692: Unit test

[patch] Bug 35692: Unit test

Bug-35692-Unit-test.patch (text/plain), 1.47 KB, created by David Nind on 2024-01-03 22:15:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-01-03 22:15:59 UTC

Size: 1.47 KB

patch

obsolete

>From eadd77cf4ef78b6976c47c98ffd508153b0982b8 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 3 Jan 2024 19:46:15 +0000
>Subject: [PATCH] Bug 35692: Unit test
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> t/db_dependent/Circulation/issue.t | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Circulation/issue.t b/t/db_dependent/Circulation/issue.t
>index c9cd7f26ff..26454a210e 100755
>--- a/t/db_dependent/Circulation/issue.t
>+++ b/t/db_dependent/Circulation/issue.t
>@@ -462,11 +462,18 @@ AddReturn( 'barcode_3', $branchcode_1 );
> $item = Koha::Items->find( $itemnumber );
> ok( $item->notforloan eq 0, q{UpdateNotForLoanStatusOnCheckin _ALL_ rules are applied if there are no specific item type rule matching the returned item} );
> 
>-t::lib::Mocks::mock_preference( 'UpdateNotForLoanStatusOnCheckin', '1: ONLYMESSAGE' );
>+t::lib::Mocks::mock_preference(
>+    'UpdateNotForLoanStatusOnCheckin', q{_ALL_:
>+        1: ONLYMESSAGE
>+}
>+);
> $item->notforloan(1)->store;
> AddReturn( 'barcode_3', $branchcode_1 );
>-$item = Koha::Items->find( $itemnumber );
>-ok( $item->notforloan eq 1, q{UpdateNotForLoanStatusOnCheckin does not update notforloan value from 1 with setting "1: ONLYMESSAGE"} );
>+$item->discard_changes;
>+ok(
>+    $item->notforloan eq 1,
>+    q{UpdateNotForLoanStatusOnCheckin does not update notforloan value from 1 with setting "1: ONLYMESSAGE"}
>+);
> 
> my $itemnumber2 = Koha::Item->new(
>     {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35692: 160499 | 160500 | 160501 | 160502